Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink BT SETTL models #125

Open
kelle opened this issue Nov 13, 2024 · 4 comments
Open

Rethink BT SETTL models #125

kelle opened this issue Nov 13, 2024 · 4 comments

Comments

@kelle
Copy link
Member

kelle commented Nov 13, 2024

Currently, the BT SETTL models are being distributed as part of this package and resulting in it being quite large. We should figure out a different way of distributing these files.

@kelle
Copy link
Member Author

kelle commented Nov 13, 2024

Actually, this atmospheric modeling aspect of the package seems "extra" and not needed for the core functionality. Maybe we can just remove the BT SETTL models? Or include a sparse grid and then include documentation about how to add any desired model grids?

@kelle kelle added this to the v2.1 milestone Nov 13, 2024
@kelle kelle changed the title Store models someplace else Rethink BT SETTL models Nov 13, 2024
@hover2pi
Copy link
Member

We could also move all the data files to a required download to make the application lighter. We do this with most of STScI's data-heavy applications.

@kelle
Copy link
Member Author

kelle commented Nov 13, 2024

Since both Jackie and Sherelyn gave the green light to remove them (on Slack), I'm going that route at the moment. I'm just deleting the btsettl/ directory and leaving the rest.

@kelle
Copy link
Member Author

kelle commented Nov 13, 2024

Removed in #126 but keeping this issue open in case we want to re-visit.

@kelle kelle removed this from the v2.1 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants