Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Backwards compatibility with Python 2.7 and unicode? #94

Open
dr-rodriguez opened this issue Oct 31, 2017 · 0 comments
Open

Backwards compatibility with Python 2.7 and unicode? #94

dr-rodriguez opened this issue Oct 31, 2017 · 0 comments

Comments

@dr-rodriguez
Copy link
Member

Saw this line and realized it would fail on python 2.7 if the user provides a unicode rather than a string:

if isinstance(dbpath, str):

If we add six to the list of requirements, we could do something like:
if isinstance(dbpath, six.string_types):
to treat both str and unicode the same way in both python 2 and 3. However, we can also get away without updating this at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant