Added Export Bonner Spreadsheet Features #1388

WackyWeaver · 2025-01-30T19:12:22Z

Issue Description

Fixes #1378

"We need more Bonner Cohort export options, to see the currently selected cohort, the last 5 years, and the current All. These spreadsheets should also show all of the bonner events and their attendees. Add columns to the sheet for each event with at least one attendee in the spreadsheet"

Changes

Created buttons associated with the new custom spreadsheets
Before
After
Updated look (thanks to feedback from Imran):
Also, created an Ajax function to associate each button to a specific flask route. We pass a start year and end year into the route using a values stored in the URL request. Then, if we want to additionally change the spreadsheet range, we can simply express a different range of values for the flask route function.
We also wrote into the bonner spreadsheet the status of each bonner requirement. If it was completed by the cohort member, we include the date of completion. If it is incomplete, we simply write "incomplete in the column of a given bonner member row.
Lastly, we wrote a SQL script to migrate the Requirementmatch table data. Since much of the Event table data did not insert the bonner requirement events into the proper requirement table, we created a script to migrate all bonner events that include the select names of a given Bonner requirement.

Testing

Use git checkout 1378-cohort-export
flask run
create a Bonner event and add a specified Bonner requirement within the drop down.
create a Bonner event with a given Bonner requirement name separate from the other specific requirement (simply to show two different Bonner events (e.i. make a Sophomore exchange and All Bonner Meeting))

…added the events attended column, and now trying to clean up makeBonnerXls logic

…tem. Will implement new logic over comign days

… overhaul logic and get events by requirementmatch, not eventparticipant

…with event date. Need to implement for Bonner Events with frequency greater than one (All Bonner Meetings)

…ts for new logic need to be implemented

…wareDevTeam/celts into 1378-cohort-export

…QL query.

…name to look cleaner

…Team/celts into 1378-cohort-export

stevensonmichel · 2025-01-31T22:40:52Z

app/static/js/bonnerManagement.js

@@ -44,6 +56,28 @@ $(document).ready(function(){
        }
    });

+    $(".export-spreadsheet").on('click', function() {


Some comments might be useful here.

Yes, they might be. However, I don't think there's any single part of the logic too esoteric to warrant any comments, if you ask me.

MImran2002 · 2025-01-31T23:05:18Z

So far it's good I follow the steps and was able to download the spreadsheet. Everything works perfectly although visually the excel sheet icon and the buttons is something that I would change but its not fundamental and important so you don't have to:

Front-end suggestion:
test case:
There are two test that failed but they are not the function you guys created, but in the app/logic/bonner.py the function you have refactor def makeBonnerXls(selectedYear, noOfYears=1): has many changes but within the text file of test_spreadsheet.py there isn't any testing for makeBonnorXls function.

I am under impression that we need to create testing for every logic so I assume there should be one but if there isn't a testing needed and my assumptions are wrong please do correct me.

I hope these suggestions helps.

MImran2002 · 2025-02-03T22:56:38Z

Yes, i see the front-end fixed, if you want the button to be all fixed size and text center this html bootstrap chunk will work:


<div class="flex-column ms-2">  
                    <br><br>
                    <button class="btn btn-success w-100 export-spreadsheet" data-years="1"><img src="static/xls-icon-3379.png" alt="Export to Excel" height="20" width="20"/> Export Selected Years</button>
                    <br><br>
                    <button class="btn btn-success w-100 export-spreadsheet" data-years="5"><img src="static/xls-icon-3379.png" alt="Export to Excel" height="20" width="20"/> Export Last 5 Years</button>
                    <br><br>
                    <button class="btn btn-success w-100 export-spreadsheet" data-years="all"><img src="static/xls-icon-3379.png" alt="Export to Excel" height="20" width="20"/> Export All Years</button>
</div>

github-actions · 2025-02-04T22:04:54Z

View Code Coverage

ojmakinde · 2025-02-04T22:38:21Z

database/oneOff/populate-requirements-match.sql

+                insert into celts.requirementmatch (requirement_id, event_id) values (5, event_id);
+            elseif event_name like '%legacy%' then 
+                insert into celts.requirementmatch (requirement_id, event_id) values (6, event_id);
+            elseif event_name like '%presentation%' then 


Hey @BrianRamsay, what do you think of this, line 35? We're trying to catch Senior Presentation. Do you think just 'presentation' is too vague? (Asking here so I don't forget in person)

MImran2002 · 2025-02-04T22:52:37Z

I am going to approve this PR after talking with James that the front-end seems awesome with new additional feature and the testing of the function as it return a spreadsheet URL is something that doesn't need to be tested.

WackyWeaver and others added 16 commits January 16, 2025 15:23

started making us and route changes for the different spreadsheets

611a310

Still fixing buttons and new routes

31b320b

Attempted a streamline of the saving process, James

581b707

Attempted to get cohorts iteratively, added the export-button class, …

0bdf28a

…added the events attended column, and now trying to clean up makeBonnerXls logic

Removed redundant logic. Established the new spreadsheet ordering sys…

05b424a

…tem. Will implement new logic over comign days

Successfully added Bonner Event columns to the Spreadsheet

6a0f6b8

Initial attempt at implementing the query logic

6a30957

Fixed the basic query for getting requirement events by name. Need to…

e17ae3b

… overhaul logic and get events by requirementmatch, not eventparticipant

Implemented query to retrieve Bonner Events and populate spreadsheet …

d3373dd

…with event date. Need to implement for Bonner Events with frequency greater than one (All Bonner Meetings)

Naive approach for All Bonner Meeting data retrieval implemented. Tes…

8277da8

…ts for new logic need to be implemented

Naive approach for All Bonner Meeting data retrieval implemented. Tes…

2399c3c

…ts for new logic need to be implemented

Merge branch '1378-cohort-export' of https://github.com/BCStudentSoft…

1e21e56

…wareDevTeam/celts into 1378-cohort-export

Wrote basics of SQL script. Need to implement

91ab003

Wrote SQL Script boilerplate. Probably doesn't work???

20d454f

Mostly fixed SQL script

7c3a03a

fixed type in SQL script and program id in test data

a5099e9

WackyWeaver marked this pull request as draft January 30, 2025 19:22

Unmerged development, due to failing prod-backup transfer. Improved S…

6d0de8d

…QL query.

ojmakinde force-pushed the 1378-cohort-export branch from 8c197db to 6d0de8d Compare January 30, 2025 21:38

ojmakinde added 2 commits January 30, 2025 17:16

Removed redundant url call in JavaScript. Modified the file download …

666ac65

…name to look cleaner

Removed test data changes

80f3889

ojmakinde requested a review from BrianRamsay January 30, 2025 22:47

Merge branch 'development' of https://github.com/BCStudentSoftwareDev…

2875a27

…Team/celts into 1378-cohort-export

WackyWeaver marked this pull request as ready for review January 31, 2025 19:38

stevensonmichel reviewed Jan 31, 2025

View reviewed changes

Added requested changes to html UI layout for spreadsheet buttons

cbe9b2a

ojmakinde added 2 commits February 4, 2025 13:00

Additional changes for added dynamism

000022e

Added the dynamic selection

6a34389

ojmakinde reviewed Feb 4, 2025

View reviewed changes

MImran2002 approved these changes Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Export Bonner Spreadsheet Features #1388

Added Export Bonner Spreadsheet Features #1388

WackyWeaver commented Jan 30, 2025 •

edited by ojmakinde

Loading

stevensonmichel Jan 31, 2025

ojmakinde Feb 3, 2025 •

edited

Loading

MImran2002 commented Jan 31, 2025 •

edited

Loading

MImran2002 commented Feb 3, 2025

github-actions bot commented Feb 4, 2025

ojmakinde Feb 4, 2025

MImran2002 commented Feb 4, 2025

Added Export Bonner Spreadsheet Features #1388

Are you sure you want to change the base?

Added Export Bonner Spreadsheet Features #1388

Conversation

WackyWeaver commented Jan 30, 2025 • edited by ojmakinde Loading

Issue Description

Changes

Testing

stevensonmichel Jan 31, 2025

Choose a reason for hiding this comment

ojmakinde Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

MImran2002 commented Jan 31, 2025 • edited Loading

MImran2002 commented Feb 3, 2025

github-actions bot commented Feb 4, 2025

ojmakinde Feb 4, 2025

Choose a reason for hiding this comment

MImran2002 commented Feb 4, 2025

WackyWeaver commented Jan 30, 2025 •

edited by ojmakinde

Loading

ojmakinde Feb 3, 2025 •

edited

Loading

MImran2002 commented Jan 31, 2025 •

edited

Loading