Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding option to run abricate on assemblies #58

Open
dfornika opened this issue Sep 19, 2024 · 0 comments
Open

Consider adding option to run abricate on assemblies #58

dfornika opened this issue Sep 19, 2024 · 0 comments

Comments

@dfornika
Copy link
Member

We have a use-case where we'd like to routinely run abricate to detect resistance genes on bacterial assemblies generated with this pipeline. We have a couple of options on how to handle this:

  • Add an optional abricate process to this pipeline
  • Create a new pipeline that's focused on running abricate

I think it's generally preferable to keep the scope of a pipeline as focused as possible, to avoid "scope creep" that can lead to accumulating complexity within the pipeline. But this may be a good opportunity to provide support for resistance gene detection in a single place that could be available to multiple projects or use-cases.

There is some precedent to taking the alternative approach of creating a separate pipeline, which is what we did for our BCCDC-PHL/mlst-nf pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant