Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes ESLint error in host project development build #54

Open
krukid opened this issue Jul 10, 2019 · 0 comments
Open

Causes ESLint error in host project development build #54

krukid opened this issue Jul 10, 2019 · 0 comments

Comments

@krukid
Copy link

krukid commented Jul 10, 2019

Steps to repro:

  1. Install addon for your project with ember install ember-cli-workbox.
  2. Ensure you have valid .eslintrc.js in project root.
  3. Either run ember s or ember build.

Environment

Using Yarn workspaces: https://yarnpkg.com/en/docs/workspaces

Result:

Build Error (broccoli-persistent-filter:EslintValidationFilter) in app/instance-initializers/sw.js

No ESLint configuration found.

Workaround 1:

Disable hinting in your project's ember-cli-build.js:

app = new EmberApp(defaults, {
  hinting: false,
  ...
})

Workaround 2:

Add the following path to .eslintignore in project's root directory:

ember-cli-workbox/

PS

Production build works out of the box as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant