Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service worker debug logging is suppressed even during local development #128

Open
robbytx opened this issue Oct 19, 2022 · 0 comments
Open

Comments

@robbytx
Copy link

robbytx commented Oct 19, 2022

Problem

During local development (using ember serve or ember build without --environment production), the Workbox service worker output is built without logging enabled. This appears to be due to the fact that the Workbox mode option defaults to production (reference), and this plugin does not set the mode option.

Desired Behavior

IMHO this plugin should pass the current Ember environment as the value for the mode option by default here.

The only hesitation I see to doing this is if the Workbox debug logging is too verbose, in which case one can set disableDevLogs: true. If others prefer not to enable this, then I propose that the mode option should at least be documented in this project's README.

Workarounds

Run NODE_ENV=development ember serve (or build), or pass the option explicitly in ember-cli-build.js:

let app = new EmberApp(defaults, {
  workbox: {
    mode: EmberApp.env()
  }
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant