diff --git a/changelog b/changelog index f93a3812d..dd386c480 100644 --- a/changelog +++ b/changelog @@ -1,5 +1,12 @@ MSAL Wiki : https://github.com/AzureAD/microsoft-authentication-library-for-android/wiki +Version 1.4.1 +- Hotfix release for Teams Dog Food. +- Fixes #1005 +- Fixes common #871 +- Limit silent thread pool to 5 threads. +- Picks up common@2.0.2-hf1 + Version 1.4.0 - Fix for MSAL #920, 924, 935, 940 * Crash due to error receiving CANCEL broadcast diff --git a/common b/common index 68ec0c72b..a2fc8557e 160000 --- a/common +++ b/common @@ -1 +1 @@ -Subproject commit 68ec0c72b84b24f044aba1ccf9999452cdc7cb72 +Subproject commit a2fc8557e15ccb20e469c633e17490881e1b97ca diff --git a/msal/build.gradle b/msal/build.gradle index c5cd92a00..221376d19 100644 --- a/msal/build.gradle +++ b/msal/build.gradle @@ -144,9 +144,9 @@ dependencies { transitive = false } - snapshotApi(group: 'com.microsoft.identity', name: 'common', version: '2.0.2', changing: true) + snapshotApi(group: 'com.microsoft.identity', name: 'common', version: '2.0.2-hf1', changing: true) - distApi("com.microsoft.identity:common:2.0.2") { + distApi("com.microsoft.identity:common:2.0.2-hf1") { transitive = false } } diff --git a/msal/src/main/java/com/microsoft/identity/client/MultipleAccountPublicClientApplication.java b/msal/src/main/java/com/microsoft/identity/client/MultipleAccountPublicClientApplication.java index 49dd50a2e..1217ff0ad 100644 --- a/msal/src/main/java/com/microsoft/identity/client/MultipleAccountPublicClientApplication.java +++ b/msal/src/main/java/com/microsoft/identity/client/MultipleAccountPublicClientApplication.java @@ -29,6 +29,7 @@ import androidx.annotation.NonNull; import androidx.annotation.Nullable; +import com.microsoft.identity.client.exception.MsalArgumentException; import com.microsoft.identity.client.exception.MsalClientException; import com.microsoft.identity.client.exception.MsalException; import com.microsoft.identity.client.internal.AsyncResult; @@ -61,6 +62,7 @@ import java.util.Map; import static com.microsoft.identity.client.internal.MsalUtils.throwOnMainThread; +import static com.microsoft.identity.client.internal.MsalUtils.validateNonNullArg; public class MultipleAccountPublicClientApplication extends PublicClientApplication implements IMultipleAccountPublicClientApplication { @@ -249,6 +251,16 @@ public void getAccount(@NonNull final String identifier, private void getAccountInternal(@NonNull final String identifier, @NonNull final GetAccountCallback callback, @NonNull final String publicApiId) { + + if(callback == null){ + throw new IllegalArgumentException("callback cannot be null or empty"); + } + try { + validateNonNullArg(identifier, "identifier"); + } catch (MsalArgumentException e) { + callback.onError(e); + } + final String methodName = ":getAccount"; com.microsoft.identity.common.internal.logging.Logger.verbose( diff --git a/msal/versioning/version.properties b/msal/versioning/version.properties index de68bfa16..d4226fe8e 100644 --- a/msal/versioning/version.properties +++ b/msal/versioning/version.properties @@ -1,3 +1,3 @@ #Wed Aug 01 15:24:11 PDT 2018 -versionName=1.4.0 +versionName=1.4.1 versionCode=0