diff --git a/changelog.txt b/changelog.txt index 6a1f88ac14..5aa5e609ec 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,5 +1,6 @@ vNext ---------- +- [MINOR] Organize browser selection classes and change signature for get AuthorizationStrategy (#2564) - [MINOR] Add Sign in With Google component for MSA federation (#2551) - [MINOR] Add SDMBroadcastReceiver for applications to register callbacks for SDM broadcasts (#2547) - [MINOR] Add switch_browser toMicrosoftStsAuthorizationRequest (#2550) diff --git a/common/src/main/java/com/microsoft/identity/common/internal/ui/AndroidAuthorizationStrategyFactory.java b/common/src/main/java/com/microsoft/identity/common/internal/ui/AndroidAuthorizationStrategyFactory.java index 35ddf33421..7311772c96 100644 --- a/common/src/main/java/com/microsoft/identity/common/internal/ui/AndroidAuthorizationStrategyFactory.java +++ b/common/src/main/java/com/microsoft/identity/common/internal/ui/AndroidAuthorizationStrategyFactory.java @@ -59,7 +59,7 @@ public class AndroidAuthorizationStrategyFactory implements IAuthorizationStrate * * @param authorizationAgent The authorization agent provided by the caller. * @param browser The browser to use for authorization. - * @param isBrowserRequest True if the request is from browser. + * @param isBrokerRequest True if the request is from broker. * @return The authorization strategy. */ @Override @@ -67,7 +67,7 @@ public class AndroidAuthorizationStrategyFactory implements IAuthorizationStrate public IAuthorizationStrategy getAuthorizationStrategy( @NonNull final AuthorizationAgent authorizationAgent, @Nullable final Browser browser, - final boolean isBrowserRequest) { + final boolean isBrokerRequest) { final String methodTag = TAG + ":getAuthorizationStrategy"; // Use embedded webView if no browser available or authorization agent is webView @@ -77,7 +77,7 @@ public IAuthorizationStrategy getAuthorizationStrategy( } Logger.info(methodTag, "Browser authorization, browser: " + browser); - return getBrowserAuthorizationStrategy(browser, isBrowserRequest); + return getBrowserAuthorizationStrategy(browser, isBrokerRequest); } /** diff --git a/common4j/src/main/com/microsoft/identity/common/java/strategies/IAuthorizationStrategyFactory.java b/common4j/src/main/com/microsoft/identity/common/java/strategies/IAuthorizationStrategyFactory.java index 6c20078b0e..708241d98c 100644 --- a/common4j/src/main/com/microsoft/identity/common/java/strategies/IAuthorizationStrategyFactory.java +++ b/common4j/src/main/com/microsoft/identity/common/java/strategies/IAuthorizationStrategyFactory.java @@ -36,6 +36,6 @@ public interface IAuthorizationStrategyFactory