Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityServer4 compatibility #1341

Closed
leastprivilege opened this issue Feb 29, 2020 · 2 comments
Closed

IdentityServer4 compatibility #1341

leastprivilege opened this issue Feb 29, 2020 · 2 comments
Assignees
Labels
Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. P1 More important, prioritize highly
Milestone

Comments

@leastprivilege
Copy link
Contributor

leastprivilege commented Feb 29, 2020

Since Brent is asking here: #1291

We need good control over the shape of the rendered JWT - e.g. the header

https://github.com/IdentityServer/IdentityServer4/blob/99ce3764c2c0dacc4d8123ce4b0055261f9b228d/src/IdentityServer4/src/Services/Default/DefaultTokenCreationService.cs#L84-L116

Also the payload

https://github.com/IdentityServer/IdentityServer4/blob/a5b17e88857b60b5b7e5e6fcfe77287c41dbb49f/src/IdentityServer4/src/Extensions/TokenExtensions.cs#L32

So whatever you are doing, please make sure that this is all still possible.

@brentschmaltz brentschmaltz self-assigned this Feb 29, 2020
@brentschmaltz brentschmaltz added Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. P1 More important, prioritize highly labels Feb 29, 2020
@brentschmaltz
Copy link
Member

brentschmaltz commented Feb 29, 2020

@leastprivilege thanks for the heads up. Our message to our partners is that we don't want to break any significant scenarios. We want to be clear, we haven't lock any specific changes and are proposing a set of changes. We looked things over and came to a conclusion that to remove dependency on NewtonSoft could result in breaking changes. We could create new types, rather than have some potential breaks.

This would lead to parallel types and would in itself cause confusion.

We are looking to our partners to help us make the best choices.

@mafurman mafurman added this to the 6.x milestone Mar 2, 2020
@brentschmaltz
Copy link
Member

@leastprivilege closing for now, if you seen any issues, please let us know ASAP as we are lobbying asp.net to internally use this release in the 5.0 release vehicle.

If we need any structural / api changes, it will be easier to get them in before 5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. P1 More important, prioritize highly
Projects
None yet
Development

No branches or pull requests

3 participants