Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip external request #786

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Feb 21, 2025

Skip external API request

The skip_on struct field tag is used to skip the external API call when only attributes that affect the internal state are modified, e.g. retry configuration. The skip_on struct field tag is a comma-separated list of operations that must be met in order to skip the field.

The provider will compare the state with the plan, and check for changes. If the only fields to be modified are those with the skip_on struct field tag set to the supplied operation, e.g. update, the provider will skip the external API call.

Only update is currently supported, as I think that's the only time this makes sense.

Separated from #745 as requested my @ms-henglu

@matt-FFFFFF matt-FFFFFF marked this pull request as ready for review February 21, 2025 16:09
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

@ms-henglu ms-henglu requested a review from magodo February 24, 2025 05:17
@ms-henglu ms-henglu merged commit f4031ef into Azure:main Feb 25, 2025
10 checks passed
@matt-FFFFFF matt-FFFFFF deleted the feat/skip branch February 25, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants