-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract retry config from resources and added default retry config #735
Open
hqhqhqhqhqhqhqhqhqhqhq
wants to merge
17
commits into
Azure:main
Choose a base branch
from
hqhqhqhqhqhqhqhqhqhqhq:fix/retryable-status-codes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5313bf8
add 429 as an retryable status code
hqhqhqhqhqhqhqhqhqhqhq e42c144
update
hqhqhqhqhqhqhqhqhqhqhq 22eb738
update
hqhqhqhqhqhqhqhqhqhqhq e00a32f
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq d7fc5da
update
hqhqhqhqhqhqhqhqhqhqhq f35993b
Update azapi_resource.go
hqhqhqhqhqhqhqhqhqhqhq a85c864
update
hqhqhqhqhqhqhqhqhqhqhq 108022b
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq 9ef5f6f
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq ff6455a
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq a6e8458
Update azapi_resource_action_ephemeral.go
hqhqhqhqhqhqhqhqhqhqhq 6fbdad7
update
hqhqhqhqhqhqhqhqhqhqhq c6a456f
Update azapi_resource.go
hqhqhqhqhqhqhqhqhqhqhq ad6d6ac
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq 4068e45
Update azapi_data_plane_resource.go
hqhqhqhqhqhqhqhqhqhqhq 535f225
Update common.go
hqhqhqhqhqhqhqhqhqhqhq 2caa155
Update common.go
hqhqhqhqhqhqhqhqhqhqhq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retry for the get after put is a special case and does not use the configuration in the resource's retry attribute. Removing the above code will cause a regression for resources deployed at MG scope, as this relies on the response check function: