Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Description for TA-000026 misleading #299

Open
nonik0 opened this issue Nov 2, 2022 · 0 comments
Open

[BUG] Description for TA-000026 misleading #299

nonik0 opened this issue Nov 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@nonik0
Copy link
Contributor

nonik0 commented Nov 2, 2022

Describe the bug

Rule TA-000026's description is "Service Fabric clusters should only use Azure Active Directory for client authentication". However, the actual rule evaluation specifically just evaluates whether AAD client auth is enabled. It does not evaluate whether other types of client auth are disabled. Service Fabric clusters also have client certificate auth in addition to AAD client auth (see docs).

Is the original intent of the rule to just check whether AAD client auth is enabled or whether AAD client auth is the only client auth enabled?

Expected behavior

Based off the current description, the rule should also validate that client certificate authentication is not enabled in addition to AAD client auth being enabled. Otherwise, the description should be updated to reflect the functionality of the rule's evaluation and simply state that the rule checks whether AAD client auth is enabled.

Reproduction Steps

N/A

Environment

N/A

@nonik0 nonik0 added bug Something isn't working 🔍 needs-triage labels Nov 2, 2022
@nonik0 nonik0 mentioned this issue Nov 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants