-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto discovery of parameter files when scanning a directory #297
Add auto discovery of parameter files when scanning a directory #297
Conversation
Regarding |
@microsoft-github-policy-service agree |
I'm thinking we probably want to do the same for analyze-template, would you mind adding that? Abstracting away the logic of the file search in a function |
…lso implemented this in AnalyzeTemplateCommandHandler, added test.
I added the same functionality in the analyze-template as well, see |
....FunctionalTests/Tests/ToTestSeparateParametersFile/TemplateWithSeparateParametersFile.bicep
Show resolved
Hide resolved
Would you also be able to add to our documentation that it uses this pararmeters path? Thank you for adding this in @pim-simons ! |
…naming standard where environment are defined (for example `azuredeploy.parameters-dev.json`)
Thanks, happy to help 👍🏻 |
Co-authored-by: Vera Bogdanich Espina <[email protected]>
....FunctionalTests/Tests/ToTestSeparateParametersFile/TemplateWithSeparateParametersFile.bicep
Show resolved
Hide resolved
src/Analyzer.Cli.FunctionalTests/Analyzer.Cli.FunctionalTests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Vera Bogdanich Espina <[email protected]>
Co-authored-by: Vera Bogdanich Espina <[email protected]>
…mons/template-analyzer into parameters-auto-discovery
Co-authored-by: Vera Bogdanich Espina <[email protected]>
Co-authored-by: Vera Bogdanich Espina <[email protected]>
…mons/template-analyzer into parameters-auto-discovery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed for me, approving!
Co-authored-by: Anais Miller <[email protected]>
Co-authored-by: Anais Miller <[email protected]>
Description
This PR adds auto discovery of parameter files when using the
analyze-directory
command. The code checks if a parameters file with naming according to Microsofts naming convention is present and if so uses this file as the input for the parameters file.Added a test
AnalyzeDirectory_ValidInputValues_AnalyzesExpectedNumberOfFilesWithParameters
to check if the parameters file is indeed used.I figured I'd try to contribute and help out since this wasn't high in the priority list, if anything is missing or not up to standards coding wise let me know!
Closes #296.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines