From 6c081462433d81dda180d151c1aba030498af867 Mon Sep 17 00:00:00 2001 From: Zhongyi Zhang Date: Fri, 19 Jul 2019 14:44:05 +0800 Subject: [PATCH] fix case sensitive issue in pqsql binding commands (#713) --- pkg/services/postgresql/common_provision.go | 6 +++--- tests/lifecycle/postgresql_cases_test.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/services/postgresql/common_provision.go b/pkg/services/postgresql/common_provision.go index 3c10a5363..2ca613884 100644 --- a/pkg/services/postgresql/common_provision.go +++ b/pkg/services/postgresql/common_provision.go @@ -153,7 +153,7 @@ func setupDatabase( } }() if _, err = tx.Exec( - fmt.Sprintf("create role %s", dbName), + fmt.Sprintf(`create role "%s"`, dbName), ); err != nil { return fmt.Errorf(`error creating role "%s": %s`, dbName, err) } @@ -163,7 +163,7 @@ func setupDatabase( // to make admin role to be a member of created db role. // Please see: https://www.postgresql.org/docs/10/role-membership.html if _, err = tx.Exec( - fmt.Sprintf("grant %s to %s", dbName, administratorLogin), + fmt.Sprintf(`grant "%s" to "%s"`, dbName, administratorLogin), ); err != nil { return fmt.Errorf( `error adding role "%s" to role "%s": %s`, @@ -174,7 +174,7 @@ func setupDatabase( } if _, err = tx.Exec( fmt.Sprintf( - "alter database %s owner to %s", + `alter database "%s" owner to "%s"`, dbName, dbName, ), diff --git a/tests/lifecycle/postgresql_cases_test.go b/tests/lifecycle/postgresql_cases_test.go index e7d76b43f..527f212a7 100644 --- a/tests/lifecycle/postgresql_cases_test.go +++ b/tests/lifecycle/postgresql_cases_test.go @@ -185,7 +185,7 @@ var postgresqlTestCases = []serviceLifecycleTestCase{ }, "backupRedundancy": "geo", "adminAccountSettings": map[string]interface{}{ - "adminUsername": "postgresqladmin", + "adminUsername": "postgresqlAdmin", "adminPassword": generate.NewPassword(), }, "serverName": uuid.NewV4().String() + "-specified",