Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove provisional image drift implementation #90

Merged
merged 5 commits into from
Jan 23, 2024
Merged

chore: remove provisional image drift implementation #90

merged 5 commits into from
Jan 23, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Jan 13, 2024 •
edited
Loading

Fixes #

Description
Removing unused code

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@Bryce-Soghigian Bryce-Soghigian added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/upgrade Issues or PRs related to Kuberentes or image upgrades labels Jan 13, 2024
Bryce-Soghigian
Bryce-Soghigian commented Jan 13, 2024
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian self-assigned this Jan 16, 2024
charliedmcb
charliedmcb requested changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd want to change this in a different way

tallaxes
tallaxes requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appropriate cleanup (until we are ready to design and implement this properly) would be remove this function altogether.

@tallaxes tallaxes changed the title chore: unparam image drift chore: remove provisional image drift implementation Jan 19, 2024
@tallaxes tallaxes added the area/drift Issues or PRs related to Drift label Jan 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7622927309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.626%
Totals Coverage Status
Change from base Build 7622897774: 0.005%
Covered Lines: 35607
Relevant Lines: 36473
💛 - Coveralls

charliedmcb
charliedmcb approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Please add to the PR description that this code removal is for dead/unused code.

@Bryce-Soghigian Bryce-Soghigian merged commit 25a02b8 into main Jan 23, 2024
7 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/unparam-image-drifted branch January 23, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallaxes tallaxes tallaxes approved these changes

@charliedmcb charliedmcb charliedmcb approved these changes

Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
area/drift Issues or PRs related to Drift area/upgrade Issues or PRs related to Kuberentes or image upgrades kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bryce-Soghigian @coveralls @tallaxes @charliedmcb