chore: Small style + usability refactors for new contributors #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are based on feedback from @matthchr
skaffold.yaml
so thatmake az-all
automated local changes during development are less confusing.NewAZClientFromAPI
vs.NewAZClient
. Maybe one of these should call the other then?NewAZClient
constructs all the clients + callsNewAZClientFromAPI
CreateAzClient
vs.NewAZClient
)var _ instance.NetworkInterfacesAPI = (*NetworkInterfacesAPI)(nil)
->var _ instance.NetworkInterfacesAPI = &NetworkInterfacesAPI{}
How was this change tested?
make presubmit
make az-all
Does this change impact docs?