Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: factored out SKUUnavailable to azure sdk for go extensions #81

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
Moved the SKUUnavailable azure parsing to the sdk for go extensions library.
How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review January 3, 2024 11:55
Copy link
Contributor

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. should we run e2e here? i think the library update being functional in unit tests is sufficient, but wanted to call it out in case they were just forgotten

@Bryce-Soghigian
Copy link
Collaborator Author

@rakechill lets still run e2e just. to be safe, but its probably fine with current coverage

Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian merged commit 3bb0a65 into main Jan 4, 2024
8 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/tech-debt-sku-unavailable branch January 4, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants