Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: removing NoError in favor of consistent Expect(err).ToNot(HaveOccurred()) throughout the codebase #681

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Feb 7, 2025

Description

Follow-up for #642

One of the cleanup items from the network interface garbage collection pr was to remove this minor helper I added. This pr does that.
How was this change tested?

  • make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@Bryce-Soghigian Bryce-Soghigian merged commit ffd73ff into main Feb 8, 2025
11 of 12 checks passed
@Bryce-Soghigian Bryce-Soghigian deleted the bsoghigian/cleanup-expect-no-error branch February 8, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants