refactor: allow getting VNET_GUID for overlay node configuration from the helm values #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Where are the tests? |
|
@juan-lee we already have tests https://github.com/Azure/karpenter-provider-azure/blob/main/pkg/providers/instancetype/suite_test.go#L524 that validate we are setting this value for overlay clusters and assert its there here but I can add more if you would like that |
matthchr
approved these changes
Feb 4, 2025
Bryce-Soghigian
deleted the
bsoghigian/removing-hard-dependency-on-vnet
branch
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #556
Description
Users using custom vnet will run into errors fetching the VNET_GUID if they haven't assigned network/VNET/READ to their cluster identity.
Let's allow populating the value in the chart, while leaving the default resolution if it's unpopulated. Note that VNET_GUID is only required for azure cni with overlay.
How was this change tested?
Does this change impact docs?
Release Note