diff --git a/charts/karpenter-crd/templates/karpenter.azure.com_aksnodeclasses.yaml b/charts/karpenter-crd/templates/karpenter.azure.com_aksnodeclasses.yaml index db6f5f00a..6311bd8bf 100644 --- a/charts/karpenter-crd/templates/karpenter.azure.com_aksnodeclasses.yaml +++ b/charts/karpenter-crd/templates/karpenter.azure.com_aksnodeclasses.yaml @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 kind: CustomResourceDefinition metadata: annotations: - controller-gen.kubebuilder.io/version: v0.17.0 + controller-gen.kubebuilder.io/version: v0.17.1 name: aksnodeclasses.karpenter.azure.com spec: group: karpenter.azure.com diff --git a/pkg/apis/crds/karpenter.azure.com_aksnodeclasses.yaml b/pkg/apis/crds/karpenter.azure.com_aksnodeclasses.yaml index db6f5f00a..6311bd8bf 100644 --- a/pkg/apis/crds/karpenter.azure.com_aksnodeclasses.yaml +++ b/pkg/apis/crds/karpenter.azure.com_aksnodeclasses.yaml @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 kind: CustomResourceDefinition metadata: annotations: - controller-gen.kubebuilder.io/version: v0.17.0 + controller-gen.kubebuilder.io/version: v0.17.1 name: aksnodeclasses.karpenter.azure.com spec: group: karpenter.azure.com diff --git a/pkg/operator/operator.go b/pkg/operator/operator.go index d2b03ed2c..1e59aa2d7 100644 --- a/pkg/operator/operator.go +++ b/pkg/operator/operator.go @@ -89,11 +89,10 @@ func NewOperator(ctx context.Context, operator *operator.Operator) (context.Cont azClient, err := instance.CreateAZClient(ctx, azConfig) lo.Must0(err, "creating Azure client") - - if options.FromContext(ctx).VnetGUID == "" && options.FromContext(ctx).NetworkPluginMode == consts.NetworkPluginModeOverlay { - vnetGUID, err := getVnetGUID(azConfig, options.FromContext(ctx).SubnetID) - lo.Must0(err, "getting VNET GUID") - options.FromContext(ctx).VnetGUID = vnetGUID + if options.FromContext(ctx).VnetGUID == "" && options.FromContext(ctx).NetworkPluginMode == consts.NetworkPluginModeOverlay { + vnetGUID, err := getVnetGUID(azConfig, options.FromContext(ctx).SubnetID) + lo.Must0(err, "getting VNET GUID") + options.FromContext(ctx).VnetGUID = vnetGUID } unavailableOfferingsCache := azurecache.NewUnavailableOfferings() diff --git a/pkg/operator/options/options.go b/pkg/operator/options/options.go index 7b644ed4f..3f1c5c53f 100644 --- a/pkg/operator/options/options.go +++ b/pkg/operator/options/options.go @@ -66,16 +66,16 @@ type Options struct { ClusterID string KubeletClientTLSBootstrapToken string // => TLSBootstrapToken in bootstrap (may need to be per node/nodepool) SSHPublicKey string // ssh.publicKeys.keyData => VM SSH public key // TODO: move to v1alpha2.AKSNodeClass? - - NetworkPlugin string // => NetworkPlugin in bootstrap - NetworkPolicy string // => NetworkPolicy in bootstrap - NetworkPluginMode string // => Network Plugin Mode is used to control the mode the network plugin should operate in. For example, "overlay" used with --network-plugin=azure will use an overlay network (non-VNET IPs) for pods in the cluster. Learn more about overlay networking here: https://learn.microsoft.com/en-us/azure/aks/azure-cni-overlay?tabs=kubectl#overview-of-overlay-networking - NetworkDataplane string - - NodeIdentities []string // => Applied onto each VM - VnetGUID string // resource guid used by azure cni for identifying the right vnet - SubnetID string // => VnetSubnetID to use (for nodes in Azure CNI Overlay and Azure CNI + pod subnet; for for nodes and pods in Azure CNI), unless overridden via AKSNodeClass - setFlags map[string]bool + + NetworkPlugin string // => NetworkPlugin in bootstrap + NetworkPolicy string // => NetworkPolicy in bootstrap + NetworkPluginMode string // => Network Plugin Mode is used to control the mode the network plugin should operate in. For example, "overlay" used with --network-plugin=azure will use an overlay network (non-VNET IPs) for pods in the cluster. Learn more about overlay networking here: https://learn.microsoft.com/en-us/azure/aks/azure-cni-overlay?tabs=kubectl#overview-of-overlay-networking + NetworkDataplane string + + NodeIdentities []string // => Applied onto each VM + VnetGUID string // resource guid used by azure cni for identifying the right vnet + SubnetID string // => VnetSubnetID to use (for nodes in Azure CNI Overlay and Azure CNI + pod subnet; for for nodes and pods in Azure CNI), unless overridden via AKSNodeClass + setFlags map[string]bool ProvisionMode string NodeBootstrappingServerURL string