Skip to content

Commit

Permalink
fix: make presubmit
Browse files Browse the repository at this point in the history
  • Loading branch information
Bryce-Soghigian authored and tomabraham committed Feb 20, 2025
1 parent 51fc9d7 commit 6fa7524
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (p ProvisionClientBootstrap) GetCustomDataAndCSE(ctx context.Context) (stri

func (p *ProvisionClientBootstrap) getNodeBootstrappingFromClient(ctx context.Context, provisionProfile *models.ProvisionProfile, provisionHelperValues *models.ProvisionHelperValues, bootstrapToken string) (string, string, error) {
transport := httptransport.New(options.FromContext(ctx).NodeBootstrappingServerURL, "/", []string{"http"})

logger := slog.New(slog.NewJSONHandler(os.Stdout, nil))
loggingClient := restlogger.NewLoggingClient(logger)
transport.Transport = loggingClient.Transport
Expand All @@ -191,7 +191,7 @@ func (p *ProvisionClientBootstrap) getNodeBootstrappingFromClient(ctx context.Co

resp, err := client.Operations.NodeBootstrappingGet(params)
if err != nil {
// As of now we just fail the provisioning given the unlikely scenario of retriable error, but could be revisted along with retriable status on the server side.
// As of now we just fail the provisioning given the unlikely scenario of retriable error, but could be revisited along with retriable status on the server side.
return "", "", err
}

Expand Down Expand Up @@ -247,7 +247,7 @@ func normalizeResourceGroupNameForLabel(resourceGroupName string) string {
}

func reverseVMMemoryOverhead(vmMemoryOverheadPercent float64, adjustedMemory float64) float64 {
// This is not the best way to do it... But will be refactored later, given that retreiving the original memory properly might involves some restructure.
// This is not the best way to do it... But will be refactored later, given that retrieving the original memory properly might involves some restructure.
// Due to the fact that it is abstracted behind the cloudprovider interface.
return adjustedMemory / (1 - vmMemoryOverheadPercent)
}
Expand Down

0 comments on commit 6fa7524

Please sign in to comment.