Skip to content

Commit

Permalink
fix: constructing mc rg
Browse files Browse the repository at this point in the history
  • Loading branch information
Bryce-Soghigian committed Feb 10, 2025
1 parent 8edfb96 commit 3bdf24f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
Empty file added .github/readme.md
Empty file.
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ jobs:
if: inputs.suite != 'Nonbehavioral'
run: |
AZURE_CLUSTER_NAME=${{ env.CLUSTER_NAME }} AZURE_RESOURCE_GROUP=${{ env.RG_NAME }} make az-creds
AZURE_SUBSCRIPTION_ID=${{ secrets.E2E_SUBSCRIPTION_ID }} AZURE_RESOURCE_GROUP_MC=MC_${{ env.RG_NAME }}_${{ env.CLUSTER_NAME }}_${{ inputs.location }} CLUSTER_NAME=${{ env.CLUSTER_NAME }} AZURE_ACR_NAME=${{ env.ACR_NAME}} TEST_SUITE="${{ inputs.suite }}" GIT_REF="$(git rev-parse HEAD)" make e2etests
AZURE_SUBSCRIPTION_ID=${{ secrets.E2E_SUBSCRIPTION_ID }} AZURE_RESOURCE_GROUP=${{ env.RG_NAME }} CLUSTER_NAME=${{ env.CLUSTER_NAME }} AZURE_ACR_NAME=${{ env.ACR_NAME}} TEST_SUITE="${{ inputs.suite }}" GIT_REF="$(git rev-parse HEAD)" make e2etests
- name: dump logs on failure
uses: ./.github/actions/e2e/dump-logs
if: failure() || cancelled()
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ e2etests: ## Run the e2e suite against your local cluster
# -count 1: prevents caching
# -timeout: If a test binary runs longer than TEST_TIMEOUT, panic
# -v: verbose output
cd test && CLUSTER_NAME=${CLUSTER_NAME} AZURE_ACR_NAME=${AZURE_ACR_NAME} AZURE_RESOURCE_GROUP_MC=${AZURE_RESOURCE_GROUP_MC} AZURE_SUBSCRIPTION_ID=${AZURE_SUBSCRIPTION_ID} AZURE_LOCATION=${AZURE_LOCATION} go test \
cd test && CLUSTER_NAME=${CLUSTER_NAME} AZURE_ACR_NAME=${AZURE_ACR_NAME} AZURE_RESOURCE_GROUP=${AZURE_RESOURCE_GROUP} AZURE_SUBSCRIPTION_ID=${AZURE_SUBSCRIPTION_ID} AZURE_LOCATION=${AZURE_LOCATION} go test \
-p 1 \
-count 1 \
-timeout ${TEST_TIMEOUT} \
Expand Down
14 changes: 9 additions & 5 deletions test/pkg/environment/azure/environment.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package azure

import (
"fmt"
"os"
"testing"

Expand Down Expand Up @@ -54,6 +55,7 @@ type Vars struct {
VNETResourceGroup string
ACRName string
ClusterName string
ClusterResourceGroup string
}
type AzureClients struct {
VNETClient *armnetwork.VirtualNetworksClient
Expand All @@ -65,16 +67,18 @@ func NewEnvironment(t *testing.T) *Environment {
azureEnv := &Environment{
Environment: env,
}
azureEnv.NodeResourceGroup = os.Getenv("AZURE_RESOURCE_GROUP_MC")
azureEnv.ClusterName = os.Getenv("AZURE_CLUSTER_NAME")
azureEnv.ClusterResourceGroup = os.Getenv("AZURE_RESOURCE_GROUP")
azureEnv.ACRName = os.Getenv("ACR_NAME")
azureEnv.Region = os.Getenv("AZURE_LOCATION")

azureEnv.NodeResourceGroup = fmt.Sprintf("MC_%s_%s_%s", azureEnv.ClusterResourceGroup, azureEnv.ClusterName, azureEnv.Region)
azureEnv.SubscriptionID = os.Getenv("AZURE_SUBSCRIPTION_ID")
azureEnv.VNETResourceGroup = os.Getenv("VNET_RESOURCE_GROUP")
if azureEnv.VNETResourceGroup == "" {
azureEnv.VNETResourceGroup = azureEnv.NodeResourceGroup
}
azureEnv.ClusterName = os.Getenv("AZURE_CLUSTER_NAME")
azureEnv.ACRName = os.Getenv("ACR_NAME")
azureEnv.Region = os.Getenv("AZURE_LOCATION")


cred, err := azidentity.NewDefaultAzureCredential(nil)
if err != nil {
panic(err)
Expand Down

0 comments on commit 3bdf24f

Please sign in to comment.