From e6fe50e3a5f3e15026587ed4d56e5e14a6a0662c Mon Sep 17 00:00:00 2001 From: Xiaoning Liu Date: Tue, 8 Jan 2019 13:48:06 +0800 Subject: [PATCH] Resolved CR comments for document changes --- file/BreakingChanges.md | 10 +++++----- file/README.md | 4 +++- file/lib/DirectoryURL.ts | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/file/BreakingChanges.md b/file/BreakingChanges.md index 4dda308..93f583c 100644 --- a/file/BreakingChanges.md +++ b/file/BreakingChanges.md @@ -2,8 +2,8 @@ 2018.01 Version 10.1.0 -* Updated convenience layer methods enum type parameters into typescript union types, this will help reducing bundle footprint. -* Updated URL encoding strategy for `url` parameters of `new XXXURL(url, pipeline)` methods, such as `new FileURL(url, pipeline)`. - * URL will accept both encoded or non-encoded URL string. It will escape non-escaped special characters, like Chinese characters. However, if directory/file name includes `%`, `url` must be encoded manually. -* `SASQueryParameters` is not going to be exported in browser bundle, and will be exported in Node.js runtime. -* IE11 needs `Array.prototype.includes` and `Object.keys` polyfills loaded. \ No newline at end of file +* Updated convenience layer methods enum type parameters into typescript union types, this will help reducing bundle footprint. +* Updated URL encoding strategy for `url` parameters of `new XXXURL(url, pipeline)` methods, such as `new FileURL(url, pipeline)`. +* URL will accept both encoded or non-encoded URL string. It will escape non-escaped special characters, like Chinese characters. However, if directory/file name includes `%`, `url` must be encoded manually. +* `SASQueryParameters` is not going to be exported in browser bundle, and will be exported in Node.js runtime. +* IE11 needs `Array.prototype.includes` and `Object.keys` polyfills loaded. \ No newline at end of file diff --git a/file/README.md b/file/README.md index 1610100..f073ffb 100644 --- a/file/README.md +++ b/file/README.md @@ -29,13 +29,15 @@ This SDK is compatible with Node.js and browsers, and validated against LTS Node You need polyfills to make this library work with IE11. The easiest way is to use [@babel/polyfill](https://babeljs.io/docs/en/babel-polyfill), or [polyfill service](https://polyfill.io/v2/docs/). Or you can load separate polyfills for missed ES feature(s). -This library depends on following ES6 features which need external polyfills loaded. +This library depends on following ES features which need external polyfills loaded. * `Promise` * `String.prototype.startsWith` * `String.prototype.endsWith` * `String.prototype.repeat` * `String.prototype.includes` +* `Array.prototype.includes` +* `Object.keys` (Override IE11's `Object.keys` with ES6 polyfill forcely to enable [ES6 behavior](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Notes)) #### Differences between Node.js and browsers diff --git a/file/lib/DirectoryURL.ts b/file/lib/DirectoryURL.ts index 737afc9..3e43d60 100644 --- a/file/lib/DirectoryURL.ts +++ b/file/lib/DirectoryURL.ts @@ -66,7 +66,7 @@ export class DirectoryURL extends StorageURL { /** * Creates a DirectoryURL object from an existing DirectoryURL. * - * @param directoryURL A DirectoryURl object + * @param directoryURL A DirectoryURL object * @param directoryName A subdirectory name */ public static fromDirectoryURL(