Bug: Inconsistent behaviour of make-mi-fic.py

[theunrepentantgeek]

Describe the bug

The Python script make-mi-fic.py is used to create a managed-identity when testing ASO during development.

When it creates an identity, the files miclientid.txt and fix.txt are created in the directory v2/out/aks-identity/azure with details that are consumed by other tasks that run later.

However, when the identity already exists, the script terminates early with the message "An identity already exists, not creating another one" without ensuring those files exist, ensuring that later task steps fail with cryptic errors.

Expected behavior

The script make-mi-fic.py should ensure the files miclientid.txt and fix.txt exist with the correct content regardless of whether the identity already existed or not.

To Reproduce

Run task to create a managed identity:

task controller:create-mi-for-workload-identity

Remove the out folder

rm -rf v2/out

Run the task again and note that the files are not recreated

task controller:create-mi-for-workload-identity

Additional context

In my original case, the files weren't created because the script make-mi-fic.py failed after creating the identity, but before creating the files. The steps given above are a synthetic way to replicate the failure conditions.

[theunrepentantgeek]

Also

• the method create_role_assignment specifies role Owner which doesn't always work
• the file azure/roleassignmentid.txt also needs to be populated.