-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data encryption - PostgreSQL Flexible Server #4298
Comments
Also, it seems we cannot supply a value from a config map for the key URIs either. |
We don't yet support creating Keys within Keyvaults, we're tracking that in #3188. I'll tag that for consideration when we triage things for our v2.11 release. Enabling configuration for the Key URIs should be straightforward; I'll check into that and report back. |
I was able to work around that by deploying a custom (in-house) operator to augment the CMK functionality. I'll look at getting it over to ASO as well when I'm not so strapped for time. As for adding the missing config map support, looks like it's just a matter of adding |
To make them configurable, yes - and I have that change in a working branch already. The most tedious bit was confirming the generated code is correct. However, I'm wondering if those are actually ARM URLs, not arbitrary ones - which would instead involve tagging them with |
We've confirmed that while these keys are URIs, they're not Azure Resource URIs - they come from the KeyVault dataplane API. PR #4311 will be merged shortly and released in the next version of ASO. |
Awesome -- looking forward to testing it. Yeah, from our tenants I can see it uses |
@theunrepentantgeek is there anywhere I can go to get a nightly / early release version of the ASOP image? I would love to test it and give you my feedback. Plus, it would simplify quite a bit of logic in my custom operator. EDIT: https://github.com/Azure/azure-service-operator/releases/tag/experimental |
It's probably something I'm doing, but I'm getting:
Barring the naming convention which I have to fix, the config map itself definitely exists in the same namespace as the FlexibleServer resource, the only difference is this config map was generated by another pipeline instead of ASO: |
You may have found a bug, related to The root cause is (I suspect):
If the above is true, we should be able to reproduce this easily too. Did you also try to use the |
You are right, if I include just the primary key URI field, it gets past that error and communicates with ARM, which (correctly) errors out:
|
I filed a bug tracking this. I'm doing related work in a related area on #2555 as well. Plan is to get this fixed before 2.10. I had realized it was an issue for the work I was doing on #2555 (which is about export) but hadn't put 2+2 together that it was already impacting existing behaviors as well for import. Thanks for the report and the patience! |
Thanks Matt! I'd be happy to test out a potential fix when it's available. I've got an internal demo / presentation coming up in two weeks to present my prototyping with ASOP and CDK8s as a potential organizational shift to these technologies, so I'm eager to get this demo wrapped up and working. |
The ASO controller uses reflection to look through the resource and find the ConfigMapReference and SecretReference fields. This reflection could miss SecretReference and ConfigMapReference fields that had been serialized into the "PropertyBag" property on the storage type. This was most common when working with preview APIs that had added new ConfigMapReference or SecretReference fields that don't exist in the GA api version. The fix is to use the converted version for reflection-based discovery. Fixes Azure#4298. Fixes Azure#4316.
The ASO controller uses reflection to look through the resource and find the ConfigMapReference and SecretReference fields. This reflection could miss SecretReference and ConfigMapReference fields that had been serialized into the "PropertyBag" property on the storage type. This was most common when working with preview APIs that had added new ConfigMapReference or SecretReference fields that don't exist in the GA api version. The fix is to use the converted version for reflection-based discovery. Fixes Azure#4298. Fixes Azure#4316.
…4330) The ASO controller uses reflection to look through the resource and find the ConfigMapReference and SecretReference fields. This reflection could miss SecretReference and ConfigMapReference fields that had been serialized into the "PropertyBag" property on the storage type. This was most common when working with preview APIs that had added new ConfigMapReference or SecretReference fields that don't exist in the GA api version. The fix is to use the converted version for reflection-based discovery. Fixes #4298. Fixes #4316.
We're about to do a release but you can try this out in the latest experimental in the meantime. Though actually it looks like it's hitting a build issue so we'll need to fix that first... will try to update here once the updated experimental is out. |
There should be an ASO 2.10 release soon, but you can try this now with the experimental release if you like. |
Thanks Matt! I'll give this a go sometime this week and report back. |
We have a policy / compliance requirement to use customer managed keys. I see that the PostgreSQL Flexible Server resource supports geoBackupKeyUri and primaryKeyUri which is great, but I don't see a way to generate those CMKs with ASOPv2. In terraform, we created one via
azurerm_key_vault_key
and gave the user-assigned managed identity access to it and nabbed the key URL from that. How can we achieve this with ASOP v2?The text was updated successfully, but these errors were encountered: