Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add support for AML registry #4041

Closed
t3mi opened this issue May 27, 2024 · 2 comments · Fixed by #4339
Closed

Feature: add support for AML registry #4041

t3mi opened this issue May 27, 2024 · 2 comments · Fixed by #4339
Assignees
@super-harsh
Labels
new-resouce-version New version of a resource ASO already supports new-resource Requests for new supported resources
Milestone
v2.10.0

Comments

@t3mi
Copy link
Contributor

t3mi commented May 27, 2024

Please add support for Azure Machine Learning registries. This would imply API version update for Microsoft.MachineLearningServices group at least to 2023-04-01.
@theunrepentantgeek theunrepentantgeek added new-resouce-version New version of a resource ASO already supports and removed new-feature labels May 27, 2024
@theunrepentantgeek theunrepentantgeek added new-resource Requests for new supported resources and removed needs-triage 🔍 labels Jun 3, 2024
@theunrepentantgeek theunrepentantgeek added this to the v2.9.0 milestone Jun 3, 2024
@matthchr
Copy link
Member

matthchr commented Jul 1, 2024

Registries were introduced in 2023-04-01, so we need to support that newer version, which is also being tracked in #3830

@theunrepentantgeek theunrepentantgeek modified the milestones: v2.9.0, v2.11.0 Aug 19, 2024
@super-harsh super-harsh modified the milestones: v2.11.0, v2.10.0 Aug 27, 2024
@super-harsh super-harsh self-assigned this Aug 27, 2024
@matthchr
Copy link
Member

In addition to adding registries, we should also update to the latest version, as per #3830 (which I've now closed). It said:

Describe the current behavior

We currently support 2021-07-01 but identified in #3772 that a couple of the properties have the wrong shape.

We don't want to change the old resources, but want to have a new version with the correct shape.

Describe the improvement

Import 2023-10-01 or later, we should use the latest available stable version at the time.

Additional context

We'll need to hand-craft the conversion for IdentityForCmk.UserAssignedIdentity and KeyVaultProperties.KeyVaultArmId for the change of shape.

@super-harsh super-harsh mentioned this issue Oct 14, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@super-harsh super-harsh

Labels
new-resouce-version New version of a resource ASO already supports new-resource Requests for new supported resources
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Add support for AML Registries Azure/azure-service-operator
4 participants
@theunrepentantgeek @matthchr @t3mi @super-harsh