Managedidentity operatorspec secrets #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehighlow
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=207eafc |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matthchr
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Overall looks good - had a few minor comments.
Waiting for external-secrets/external-secrets#3367 before this merges, as that is the main use-case.
| return nil, nil | ||
| } | ||
|
|
||
| // obj.Status.ClientId |
There was a problem hiding this comment.
minor: Is this comment needed?
There was a problem hiding this comment.
No, that was a part of debugging. Removed.
v2/api/managedidentity/customizations/user_assigned_identity_extention_authorization.go
Show resolved
Hide resolved
added 3 commits
April 18, 2024 09:44
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ok-to-test sha=9a7af94 |
matthchr
approved these changes
Apr 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3936
What this PR does / why we need it:
This PR adds secrets section to the
operatorSpecof theUserAssignedIdentitySpecial notes for your reviewer:
How does this PR make you feel:
If applicable: