Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM: User #3652

Closed
wants to merge 15 commits into from
Closed

APIM: User #3652

wants to merge 15 commits into from

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Dec 14, 2023

Relates to #3398

This adds the APIM User resource which could be used when created a Subscription

Special notes for your reviewer:

  • No integration tests currently

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@codecov-commenter
Copy link

Codecov Report

Attention: 551 lines in your changes are missing coverage. Please review.

Comparison is base (5bac6d1) 53.50% compared to head (c1bb497) 53.45%.

Files Patch % Lines
.../api/apimanagement/v1api20220801/user_types_gen.go 33.47% 437 Missing and 34 partials ⚠️
...management/v1api20220801/storage/user_types_gen.go 3.27% 59 Missing ⚠️
...1api20210601/workspaces_big_data_pool_types_gen.go 27.27% 7 Missing and 1 partial ⚠️
...2/internal/controllers/controller_resources_gen.go 72.00% 7 Missing ⚠️
...t/v1api20220801/service_user_spec_arm_types_gen.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
- Coverage   53.50%   53.45%   -0.05%     
==========================================
  Files        1364     1368       +4     
  Lines      461340   462153     +813     
==========================================
+ Hits       246829   247039     +210     
- Misses     177522   178088     +566     
- Partials    36989    37026      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr
Copy link
Member

@ross-p-smith - is this still active? Should we close this? or do you need somebody to take it over?

cc @tomkerkhove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants