Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable max backoff for ASO polling #2584

Closed
matthchr opened this issue Nov 4, 2022 · 5 comments
Closed

Configurable max backoff for ASO polling #2584

matthchr opened this issue Nov 4, 2022 · 5 comments
Labels
low-priority Low priority item. We'll get to it eventually.

Comments

@matthchr
Copy link
Member

matthchr commented Nov 4, 2022

Describe the current behavior
The polling speeds are hardcoded in ASO.

Describe the improvement
The polling speed could be configurable, either at a per-resource level using annotations or at the whole operator level via an option in the aso-controller-settings secret.

@matthchr matthchr added the task label Nov 4, 2022
@matthchr matthchr mentioned this issue Nov 4, 2022
2 tasks
@matthchr matthchr added low-priority Low priority item. We'll get to it eventually. and removed needs-triage 🔍 labels Nov 7, 2022
@matthchr matthchr added this to the v2.0.0-beta.5 milestone Nov 7, 2022
@matthchr
Copy link
Member Author

matthchr commented Nov 7, 2022

We're not 100% sure we actually want to expose this as a configuration because it feels like something that people might shoot themselves in the foot with. We'll leave this item open for now and if/when we revisit this in a few months if there's desire for this we may do it, but if there's not we may close it.

@StephanSalas
Copy link

Perhaps polling speed could be configurable to a limit so that folks can't shoot themselves in the foot without compiling golang code. That would be an interesting compromise.

@matthchr
Copy link
Member Author

matthchr commented May 1, 2023

We're still thinking about this

@matthchr
Copy link
Member Author

No change from above. Some polling is already configurable (the AZURE_SYNC_PERIOD). We've had much fewer issues with throttling since the improvements we've made so currently not planning on implementing this unless a new need arises.

@matthchr
Copy link
Member Author

Closing this as it seems that the current backoffs we have are working well, we haven't seen throttling issues in ages and we'd prefer if the defaults "just worked" rather than requiring the users to tune them.

@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low priority item. We'll get to it eventually.
Projects
Development

No branches or pull requests

3 participants