Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Management Groups and Policies #2249

Open
jamesgoodhouse opened this issue Apr 25, 2022 · 7 comments
Open

Feature: Management Groups and Policies #2249

jamesgoodhouse opened this issue Apr 25, 2022 · 7 comments
Labels
new-feature new-resource Requests for new supported resources

Comments

@jamesgoodhouse
Copy link

We're looking into leverage the Azure Service Operator for managing higher level resources for managing individual subscriptions and related things like management groups and their policies among other thing. I do not believe this is currently part of the support resources, but i wanted to see if this is on the roadmap, or if PRs would be accepted for adding the resources?

@matthchr
Copy link
Member

We're definitely interested in supporting these sorts of resources. Do you have a concrete list of what all you need? Obviously Microsoft.Management/managementGroups, Microsoft.Subscription/subscriptionDefinitions, and probably Microsoft.Subscription/policies.

What else?

We would be open to a PR, but just be aware that supporting these resources might be a bit more complicated than it first seems. The complexity here comes with these being root resources that impact how owner resolution is done. If you see resolver.go, resources that are "roots" (RG, Subscription, Tenant, Management Group) have to implement genruntime.NamespacedResourceReference. That's in itself not a problem but it means that we'd possibly want to add support for code-generating those resources (assuming they have Swaggers, I'd need to check). We don't codegen that right now because at least at the time we wrote the generator ResourceGroup didn't have a great Swagger spec.

It's also possible that some updates would need to be made to the azure_generic_arm_reconciler provisioning logic... although I took a look and it does seem like it might just work as is...

@jamesgoodhouse
Copy link
Author

Those are the main resources that come to mind. We're still in the early stages of determining our account structure/hierarchy and I am still ramping up on what pieces we will need to automate.

I believe they would be able to leverage code-generation, as I see schemas existing in https://github.com/Azure/azure-resource-manager-schemas.

@matthchr matthchr added the new-resource Requests for new supported resources label Apr 26, 2022
@matthchr matthchr added this to the v2.0.0-beta.1 milestone May 2, 2022
@matthchr matthchr self-assigned this May 16, 2022
@matthchr matthchr modified the milestones: v2.0.0-beta.1, v2.0.0-beta.2 Jun 13, 2022
@matthchr
Copy link
Member

matthchr commented Jul 7, 2022

Some implementation notes for this: Subscriptions Swagger is here and there's a JSON schema here.

The JSON schema roots up to https://schema.management.azure.com/schemas/2019-08-01/tenantDeploymentTemplate.json, rather than the normal https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json. We don't currently read https://schema.management.azure.com/schemas/2019-08-01/tenantDeploymentTemplate.json so we'll need to add that as part of supporting this.

@matthchr matthchr modified the milestones: v2.0.0-beta.3, v2.0.0-beta.2 Aug 1, 2022
@matthchr matthchr changed the title Feature: Account-Level Resources Feature: Management Groups and Policies Aug 15, 2022
@matthchr
Copy link
Member

Creating and canceling subscriptions support was added in #2446. I've changed the title of this issue to correctly reflect the remaining work which is not yet supported (Creating/deleting management groups or policies).

@matthchr matthchr removed their assignment Jun 5, 2023
@matthchr matthchr modified the milestones: v2.2.0, v2.3.0 Jul 6, 2023
@matthchr matthchr modified the milestones: v2.4.0, v2.3.0 Jul 24, 2023
@matthchr matthchr modified the milestones: v2.3.0, v2.4.0 Aug 28, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr
Copy link
Member

matthchr commented Apr 8, 2024

Still interested in doing this

@theunrepentantgeek
Copy link
Member

No change from the above.

@jamesgoodhouse
Copy link
Author

I'm no longer working with Azure at the moment, but I'm sure this would still be a great addition if someone is able to put together a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature new-resource Requests for new supported resources
Projects
Development

No branches or pull requests

3 participants