Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow storing secrets in KeyVault #2242

Open
matthchr opened this issue Apr 19, 2022 · 6 comments
Open

Feature: Allow storing secrets in KeyVault #2242

matthchr opened this issue Apr 19, 2022 · 6 comments
Assignees
Labels
asov1-gap documentation Improvements or additions to documentation new-feature
Milestone

Comments

@matthchr
Copy link
Member

This was brought up in #1894 and also supported in ASOv1.

This is related to #1415 which was originally for ASOv1 but would apply to ASOv2 as well if it had KV support.

@matthchr
Copy link
Member Author

This is still something that we're tracking. There are various solutions to reading KeyVault secrets into Kubernetes, for example:
https://external-secrets.io/ and https://docs.microsoft.com/en-us/azure/aks/csi-secrets-store-driver, but there aren't any inbuilt solutions for exporting secrets (say, storage account keys) to those stores securely.

@matthchr
Copy link
Member Author

Still something worth doing but hasn't been a lot of clamor for it yet

@epierotto
Copy link

I'm also interested on this feature, I wanted to provision an Azure KeyVault along with some secrets.
Initially I thought that I would find an ASO resource similar to "Microsoft.KeyVault/vaults/secrets"

@matthchr
Copy link
Member Author

I'm also interested on this feature, I wanted to provision an Azure KeyVault along with some secrets. Initially I thought that I would find an ASO resource similar to "Microsoft.KeyVault/vaults/secrets"

We purposefully had chosen not to do secret creation via ASO because it felt like these two goals were in conflict:

  1. KeyVault wants you to store your secrets only there, so they're the most secure.
  2. ASO must store the secret in Kubernetes somehow, in order to know what value to propagate to KeyVault when creating a new secret.

Can you expand more on why you want your secrets in KeyVault and Kubernetes? Can you give some (high level) examples of the scenarios you're looking to solve? Understanding those might help us to revisit the decision mentioned above and consider supporting KV key management through ASO.

@theunrepentantgeek theunrepentantgeek modified the milestones: v2.2.0, v2.3.0 Jul 3, 2023
@matthchr matthchr modified the milestones: v2.4.0, v2.3.0 Jul 24, 2023
@matthchr matthchr modified the milestones: v2.3.0, v2.4.0 Aug 28, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.5.0, v2.4.0 Sep 7, 2023
@matthchr matthchr modified the milestones: v2.4.0, v2.5.0 Oct 23, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.5.0 Nov 14, 2023
@matthchr matthchr modified the milestones: v2.5.0, v2.6.0 Dec 4, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr
Copy link
Member Author

matthchr commented Apr 8, 2024

At this point this feels more like a documentation thing as I believe there are projects that achieve this without needing to be as explicit about it as ASOv1 was. We need to close at least the doc gap though if not the actual feature gap.

@matthchr matthchr added this to the v2.8.0 milestone Apr 8, 2024
@matthchr matthchr self-assigned this Apr 8, 2024
@matthchr matthchr added the documentation Improvements or additions to documentation label Apr 29, 2024
@matthchr matthchr modified the milestones: v2.8.0, v2.9.0 Jun 17, 2024
@cvs79
Copy link

cvs79 commented Aug 13, 2024

This would still benefit customers.

for example, for a current customer we do not expose kubernetes and Azure directly to end users. This could be employees or third-party users. We do expose selfservice repos which they have access to. Contents from this are synced to the cluster using ArgoCD. This can include APIM resources (ex. products) but also secrets (encrypted using sops decrypted by ArgoCD).

But sometimes other azure resources would need a secret from KV. Creating this from ASOv2 would greatly simplify that without installing another operator.

@matthchr matthchr modified the milestones: v2.9.0, v2.10.0, v2.11.0 Aug 22, 2024
@matthchr matthchr modified the milestones: v2.11.0, v2.12.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asov1-gap documentation Improvements or additions to documentation new-feature
Projects
Development

No branches or pull requests

4 participants