Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more stages for golden tests #1853

Closed
theunrepentantgeek opened this issue Oct 5, 2021 · 5 comments
Closed

Enable more stages for golden tests #1853

theunrepentantgeek opened this issue Oct 5, 2021 · 5 comments
Assignees
Milestone

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

For a number of reasons that were logical at the time, we are currently suppressing/excluding a large number of pipeline stages in NewTestCodeGenerator().

Revisting the list of suppressions in the context of PR #1851, both @matthchr and myself believe that many of these should now be enabled.

Doing so will create a lot of churn in the golden file output from the tests, requiring some close reading to spot anything untoward, so we want to make those changes in a separate PR.

@theunrepentantgeek
Copy link
Member Author

Still required, but should be done at the same time as #2150.

@matthchr
Copy link
Member

Some improvements have been made here but there's more to do. Might make sense to do after #2084

@matthchr
Copy link
Member

matthchr commented Feb 7, 2023

May not actually need to do this -- what we need to do is move off JSON to Swagger

@theunrepentantgeek
Copy link
Member Author

Retaining for now. @theunrepentantgeek to investigate whether we need these.

@theunrepentantgeek
Copy link
Member Author

No longer required; we've decreased the number of suppressions organically and most of the remaining ones make sense.

@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Nov 7, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.4.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants