-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more stages for golden tests #1853
Comments
Still required, but should be done at the same time as #2150. |
Some improvements have been made here but there's more to do. Might make sense to do after #2084 |
May not actually need to do this -- what we need to do is move off JSON to Swagger |
Retaining for now. @theunrepentantgeek to investigate whether we need these. |
No longer required; we've decreased the number of suppressions organically and most of the remaining ones make sense. |
Describe the current behavior
For a number of reasons that were logical at the time, we are currently suppressing/excluding a large number of pipeline stages in
NewTestCodeGenerator()
.Revisting the list of suppressions in the context of PR #1851, both @matthchr and myself believe that many of these should now be enabled.
Doing so will create a lot of churn in the golden file output from the tests, requiring some close reading to spot anything untoward, so we want to make those changes in a separate PR.
The text was updated successfully, but these errors were encountered: