Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Runtime exceptions aggregate #6169

Open
3 tasks
konrad-jamrozik opened this issue May 12, 2023 · 15 comments
Open
3 tasks

[Breaking Change] Runtime exceptions aggregate #6169

konrad-jamrozik opened this issue May 12, 2023 · 15 comments
Assignees
Labels
Breaking Changes Improvements to Breaking Changes tooling bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented May 12, 2023

Note: the list below is competing for priority with

This is an aggregate issue for Breaking Change runtime exceptions:

And from the old, pre-transfer backlog:

Related issue:

Errors reported after 9/11

I.e. after the runtime exception fix got merged and deployed.

References

For more, see comments below.

Konrad's private OneNote page for this issue is #6169 [Breaking Change] Runtime exceptions aggregate

@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels May 12, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this May 12, 2023
@konrad-jamrozik konrad-jamrozik changed the title [Breaking Change] Runtime Exceptions [Breaking Change] runtime exceptions list May 12, 2023
@konrad-jamrozik konrad-jamrozik changed the title [Breaking Change] runtime exceptions list [Breaking Change] runtime exceptions aggregate May 12, 2023
@konrad-jamrozik
Copy link
Contributor Author

@konrad-jamrozik konrad-jamrozik changed the title [Breaking Change] runtime exceptions aggregate [Breaking Change] Runtime exceptions aggregate Jun 8, 2023
@mikekistler mikekistler added Breaking Changes Improvements to Breaking Changes tooling bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Jun 19, 2023
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jun 29, 2023

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jul 10, 2023

Info from Ray about known limitation in this Teams discussion:

There's a known limitation in the pipeline to remove the label when the new commit was pushed to the PR to remove the breaking change.

@konrad-jamrozik
Copy link
Contributor Author

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jul 31, 2023

Another case:

Some clues from the error log:

ERROR: Schema violation: Missing required property: name\n - file:///mnt/vss/work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/Language/stable/2022-05-01/analyzeconversations.json:2077:10 ($.definitions.apimkey.properties.name["x-ms-enum"])\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.\n"

@konrad-jamrozik
Copy link
Contributor Author

Another case:

The tool detected the breaking change, but then failed with runtime error, so it never produced the signal required for automation to add necessary labels.

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Aug 18, 2023

Another one:

This case denotes the runtime exception may possibly be caused by the tool trying to compare to a non-existent file.

@konrad-jamrozik
Copy link
Contributor Author

@konrad-jamrozik
Copy link
Contributor Author

I did analysis and bucketing of some of the runtime errors. See here:

@konrad-jamrozik
Copy link
Contributor Author

So far big chunk of this work was addressed by:

  • Pull Request 500754: Implement support for pretty-printing runtime errors originating from AutoRest invocation from within OAD (breaking change detector)

@konrad-jamrozik
Copy link
Contributor Author

Closing for now. May revisit with future work later. For now we identified more urgent work.

@konrad-jamrozik
Copy link
Contributor Author

Reopening for Dilithium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Changes Improvements to Breaking Changes tooling bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Archived in project
Status: 🎊 Closed
Development

No branches or pull requests

2 participants