From e79178a8406aa80294080950fcb7a57ee88dffbf Mon Sep 17 00:00:00 2001 From: Deyaaeldeen Almahallawi Date: Thu, 21 Nov 2024 06:46:29 -0800 Subject: [PATCH 1/3] [OpenAI] Fix browser tests --- sdk/openai/openai/tsconfig.browser.config.json | 3 ++- sdk/openai/openai/tsconfig.samples.json | 2 +- sdk/openai/openai/vitest.browser.config.ts | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/sdk/openai/openai/tsconfig.browser.config.json b/sdk/openai/openai/tsconfig.browser.config.json index 7eafd57faa8c..e420545054f4 100644 --- a/sdk/openai/openai/tsconfig.browser.config.json +++ b/sdk/openai/openai/tsconfig.browser.config.json @@ -4,6 +4,7 @@ "exclude": ["./test/**/node/**/*.ts"], "compilerOptions": { "outDir": "./dist-test/browser", - "composite": true + "rootDir": ".", + "noEmit": false } } diff --git a/sdk/openai/openai/tsconfig.samples.json b/sdk/openai/openai/tsconfig.samples.json index 95150971070e..c2431edd544f 100644 --- a/sdk/openai/openai/tsconfig.samples.json +++ b/sdk/openai/openai/tsconfig.samples.json @@ -5,7 +5,7 @@ "module": "NodeNext", "moduleResolution": "NodeNext", "paths": { - "@azure/openai": ["./dist/esm/index.js"] + "@azure/openai": ["./dist/esm"] }, "noEmit": true, "composite": true diff --git a/sdk/openai/openai/vitest.browser.config.ts b/sdk/openai/openai/vitest.browser.config.ts index 1e778312fb67..5be878d6308c 100644 --- a/sdk/openai/openai/vitest.browser.config.ts +++ b/sdk/openai/openai/vitest.browser.config.ts @@ -4,6 +4,7 @@ import { defineConfig, mergeConfig } from "vitest/config"; import viteConfig from "../../../vitest.browser.shared.config.ts"; +import { resolve } from "node:path"; export default mergeConfig( viteConfig, @@ -16,6 +17,10 @@ export default mergeConfig( include: [ "dist-test/browser/test/**/*.spec.js", ], + alias: { + "@azure/openai": resolve("./dist/browser/index.js"), + "../../dist/esm": resolve("./dist/browser"), + }, }, }), ); From 965a08479370b12a1096872145597f9b14155dec Mon Sep 17 00:00:00 2001 From: Deyaaeldeen Almahallawi Date: Thu, 21 Nov 2024 13:37:27 -0800 Subject: [PATCH 2/3] add alias for the sub path --- sdk/openai/openai/vitest.browser.config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/openai/openai/vitest.browser.config.ts b/sdk/openai/openai/vitest.browser.config.ts index 5be878d6308c..6ebd339dfed5 100644 --- a/sdk/openai/openai/vitest.browser.config.ts +++ b/sdk/openai/openai/vitest.browser.config.ts @@ -19,6 +19,7 @@ export default mergeConfig( ], alias: { "@azure/openai": resolve("./dist/browser/index.js"), + "@azure/openai/types": resolve("./dist/browser/types/index.js"), "../../dist/esm": resolve("./dist/browser"), }, }, From a2be5e9839d56fbd53be5febd6f93343cec7f418 Mon Sep 17 00:00:00 2001 From: Deyaaeldeen Almahallawi Date: Sat, 23 Nov 2024 05:51:08 -0800 Subject: [PATCH 3/3] swap order --- sdk/openai/openai/vitest.browser.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/openai/openai/vitest.browser.config.ts b/sdk/openai/openai/vitest.browser.config.ts index 6ebd339dfed5..0f08902325d9 100644 --- a/sdk/openai/openai/vitest.browser.config.ts +++ b/sdk/openai/openai/vitest.browser.config.ts @@ -18,8 +18,8 @@ export default mergeConfig( "dist-test/browser/test/**/*.spec.js", ], alias: { - "@azure/openai": resolve("./dist/browser/index.js"), "@azure/openai/types": resolve("./dist/browser/types/index.js"), + "@azure/openai": resolve("./dist/browser/index.js"), "../../dist/esm": resolve("./dist/browser"), }, },