Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor - Query] MetricsClient live tests > getMetricDefinitions -> queryMetrics failing in nightly runs #32413

Open
jerryshia opened this issue Jan 3, 2025 · 0 comments
Open

[Monitor - Query] MetricsClient live tests > getMetricDefinitions -> queryMetrics failing in nightly runs #32413

jerryshia opened this issue Jan 3, 2025 · 0 comments
Assignees
@sarangan12 @KarishmaGhiya
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query test-reliability Issue that causes tests to be unreliable

Comments

@jerryshia
Copy link
Member

Monitor - Query nightly test runs are failing with:

Error message：
Test timed out in 18000ms. If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".

Stack trace：

Error: Test timed out in 18000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".

For more details check here:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4448460&view=results
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 3, 2025
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 3, 2025
@srnagar srnagar assigned KarishmaGhiya and sarangan12 and unassigned srnagar Jan 3, 2025
@sarangan12 sarangan12 mentioned this issue Jan 3, 2025
Merged
3 tasks
sarangan12 added a commit that referenced this issue Jan 4, 2025
@sarangan12
[@azure/monitor-query] Skip failing test in the Monitor Query SDK (#3…
c7937b8 
…2419)

### Packages impacted by this PR

`@azure/monitor-query`

### Issues associated with this PR

#32413

### Describe the problem that is addressed by this PR

An issue #32413 has been
created to address the live tests pipeline failure for Monitor Query
SDK. On analysis, I have found that there is only one test failing in
the pipeline i.e. `LogsQueryClient live tests - server timeout` in
`logsQueryClient.spec.ts` file.

Now, if I look into this test, here is the logic:
1. Execute a query `range x from 1 to ${randomLimit} step 1 | count`
with the `serverTimeoutInSeconds` set to 1.
2. This query is supposed to encounter a timeout error and be thrown.
(If you look at the recordings in playback mode, you can confirm that
the error is thrown).
3. But, now with the live mode the error is not thrown. As a result, the
test is failing.

So, I wanted to discuss this with the service team to understand what
has changed and probably update the query to ensure that the error is
thrown. But, until that I do not want the live tests pipeline to be
blocked. So, I am skipping this test for now. But, I will not be closing
the original issue until I put in a permanent fix for the same.

With the skipped test, I was able to run the live tests and confirm it
is working fine. Here is the link:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4450540&view=results

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

No special design considerations.

### Are there test cases added in this PR? _(If not, why?)_

No. The error itself is happening in a test case.

### Provide a list of related PRs _(if any)_

None

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

None

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarangan12 sarangan12

@KarishmaGhiya KarishmaGhiya

Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sarangan12 @KarishmaGhiya @srnagar @v-xuto @jerryshia