[mgmt] migrate mgmt package to esm 9 #32366
Conversation
kazrael2119
requested review from
qiaozha,
MaryGao,
a team,
ckairen and
jeremymeng
as code owners
github-actions
bot
added
the
Mgmt
|
API change check API changes are not detected in this pull request. |
| "esm", | ||
| "commonjs" | ||
| ], | ||
| "esmDialects": [ |
There was a problem hiding this comment.
Are we shipping for React-Native and Browser support? If not, please remove the esmDialects.
There was a problem hiding this comment.
@mpodwysocki do you see any potential risk of adding this support? When we deprecated the very older version of Node SDK, we have this deprecation message "This package is deprecated in favor of @azure/arm-compute whick works both on node.js and browsers" See link which are actually from Ramya at that time, but we do have been ignoring the browser test for mgmt plane https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/databox/arm-databox/package.json#L80 so I was not sure if we want this or not
Perhaps @xirzec has some thoughts here ?
There was a problem hiding this comment.
After some offline discussion with @mpodwysocki, we are fine with keeping this. Going to merge this for now. @xirzec feel free to let me know if you have any concerns, we can always revisit this :)
There was a problem hiding this comment.
@qiaozha @mpodwysocki since we shipped browser supported code in dist, should we enable the browser testing also?
Currently we skipped broswer testing by default, not sure any reason not doing that?
azure-sdk-for-js/sdk/databox/arm-databox/package.json
Lines 70 to 76 in 0bcbed4
#32184
@azure/arm-databox
@azure/arm-databoxedge
@azure/arm-databoxedge-profile-2020-09-01-hybrid
@azure/arm-databricks
@azure/arm-datacatalog