Added extra hardening security #31933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisribe
requested review from
deyaaeldeen,
jeremymeng and
a team
as code owners
|
API change check API changes are not detected in this pull request. |
jeremymeng
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created storage was being flagged by security wave.
All tests passing after changes and advisor recommendations all green.
Packages impacted by this PR
@azure/arm-healthdataaiservices
Issues associated with this PR
Created storage being flagged by security wave.
Storage should be Identity-Based Access Control, and then apply the AllowSharedKeyAccess = false
https://eng.ms/docs/products/azure-storage/security/standards/identity-based-access
Describe the problem that is addressed by this PR
Service 360 flag
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Followed recommended settings here and applied same settings used in main service.
https://eng.ms/docs/products/azure-storage/security/standards/identity-based-access
Are there test cases added in this PR? (If not, why?)
No, only storage settings.
Provide a list of related PRs (if any)
Related only where the New-TestResources.ps1 cmd fails without this PR (missing test data).
#31921
Command used to generate this PR:**(Applicable only to SDK release request PRs)
..\..\..\eng\common\TestResources\New-TestResources.ps1 -ServiceDirectory healthdataaiservices -UserAuth -BaseName demo1 -Subscription a49b70b4-60ee-4422-a7e2-xyz -DeleteAfterHours 8Checklists