[keyvault] KeyVault Admin deployment fixes #31817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run js - keyvault-admin - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
maorleger
force-pushed
the
fix-backup-keyvault
branch
from
c498f6f to
5f16d03
Compare
|
TODO: Connect-AzAccount once #31335 is merged in order to refresh the credential but I tested this locally and am able to backup/restore using these credentials |
maorleger
requested review from
deyaaeldeen,
jeremymeng,
a team and
timovv
as code owners
timovv
approved these changes
Dec 2, 2024
maorleger
force-pushed
the
fix-backup-keyvault
branch
from
fa31e8c to
9a88f00
Compare
|
/check-enforcer override |
|
(failure is unrelated due to flaky test in appconfig) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/keyvault-admin
@azure/keyvault-keys (somewhat)
Issues associated with this PR
Resolves #30273
Describe the problem that is addressed by this PR
As part of the recent changes removing SAS tokens from our deployment we
disabled backup and restore keyvault tests. This PR re-enables them by
configuring a user assigned managed identity and associating it with the correct
resources. Omitting the sasToken parameter will allow the SDK to use managed
identity and thus re-enable backup/restore tests.
In passing I also noticed that the deployment happens twice: once via ARM and once via bicep. I went
ahead and removed the arm template so that we only need to worry about bicep
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists