Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 9381 #31816

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9381 See eng/common workflow

…f we don't have an artifact details at all, don't verify changelog. if we do, but skipverifychangelog is present, don't verify changelog. if we have artifact details, but no disable, verify the changelog
@azure-sdk azure-sdk requested a review from a team as a code owner November 18, 2024 19:50
@azure-sdk azure-sdk requested a review from scbedd November 18, 2024 19:50
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Nov 18, 2024
@scbedd
Copy link
Member

scbedd commented Nov 18, 2024

/azp run js - pullrequest

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator Author

API change check

API changes are not detected in this pull request.

@scbedd
Copy link
Member

scbedd commented Nov 18, 2024

The failing analyze on js - template is most definitely a wonky merge commit checkout. Going to /check-enforcer override and ignore.

@scbedd
Copy link
Member

scbedd commented Nov 18, 2024

/check-enforcer override

Failures are not related to this change.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is unrelated to the code change. js - pullrequest analyze phase is passing for the changelog, so the one failure on js - template has got to be a merge commit issue. Going to override and merge.

@scbedd scbedd merged commit 5edf27a into main Nov 18, 2024
20 of 24 checks passed
@scbedd scbedd deleted the sync-eng/common-handle-missing-artifacts-9381 branch November 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants