Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys][generate-doc] add subpath exports support #31699

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

jeremymeng
Copy link
Member

No description provided.

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danieljurek
Copy link
Member

Docs tool outputs 👍 :

process.cwd = /mnt/vss/_work/1/s
Path: /mnt/vss/_work/1/s/sdk/openai/openai
checks after walk: {
  "isPrivate": false,
  "srcPresent": true,
  "srcIndexPresent": true,
  "version": "2.0.0-beta.4",
  "packageName": "@azure/openai"
}
  entrypoints: ["src/index.ts","src/types/index.ts"]
[info] Documentation generated at /mnt/vss/_work/1/s/docGen/azure-openai/2.0.0-beta.4
All done!

Docs produced 👍 :

image

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for tool output difference (produces more). @deyaaeldeen or @minhanh-phan may have comments about the content.

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
@jeremymeng
Copy link
Member Author

/check-enforcer override

@jeremymeng
Copy link
Member Author

@microsoft-github-policy-service agree

@jeremymeng
Copy link
Member Author

/check-enforcer evaluate

@jeremymeng jeremymeng closed this Nov 22, 2024
@jeremymeng jeremymeng reopened this Nov 22, 2024
@jeremymeng jeremymeng merged commit 1b30075 into Azure:main Nov 22, 2024
28 checks passed
@jeremymeng jeremymeng deleted the engsys/generate-doc-subpaths branch November 22, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants