[ts-http-runtime] minimal API surface #31627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
timovv
force-pushed
the
ts-http-runtime/trim
branch
2 times, most recently
from
df4479c to
d58a2b5
Compare
timovv
force-pushed
the
ts-http-runtime/trim
branch
from
7b2581f to
288e1eb
Compare
joheredi
reviewed
Dec 2, 2024
joheredi
approved these changes
Dec 2, 2024
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Dec 17, 2024
Document Intelligence bumping its `typescript` dev dependency version to ~5.7.2, and caused some other packages to also use ~5.7.2. This leads to the build error in ts-http-runtime, where newer version of lib.dom.d.ts expects `bytes` property in `File` type. `bytes` property was added previously in PR Azure#31990, but got removed in PR Azure#31627 maybe due to bad merge? It also seems to be a pnpm or rush bug that the pnpm-lock.yaml file have [email protected] for other packages that depends on ~5.6.2, for example, ts-http-runtime: https://github.com/Azure/azure-sdk-for-js/blob/8a7d4e90ac3795b0494653eb04cebd6bc0f3213d/common/config/rush/pnpm-lock.yaml#L19848 This also results in api.md changes for RestError's `[custom]` logging method. While we investigate further into that, this PR should restore js - core pipeline to green status.
jeremymeng
added a commit
that referenced
this pull request
Dec 17, 2024
Document Intelligence bumping its `typescript` dev dependency version to ~5.7.2, and caused some other packages to also use ~5.7.2. This leads to the build error in ts-http-runtime, where newer version of lib.dom.d.ts expects `bytes` property in `File` type. `bytes` property was added previously in PR #31990, but got removed in PR #31627 maybe due to bad merge? It also seems to be a pnpm or rush bug that the pnpm-lock.yaml file have [email protected] for other packages that depends on ~5.6.2, for example, ts-http-runtime: https://github.com/Azure/azure-sdk-for-js/blob/8a7d4e90ac3795b0494653eb04cebd6bc0f3213d/common/config/rush/pnpm-lock.yaml#L19848 This also results in api.md changes for RestError's `[custom]` logging method. While we investigate further into that, this PR should restore js - core pipeline to green status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@typespec/ts-http-runtimeDescribe the problem that is addressed by this PR
We're preparing for an initial release of this package. This PR pares back the unbranded Core's exports to the smallest possible API surface necessary which will still allow code generated by the Modular emitter to work.
The idea is that in time, much (if not all) of the surface that this PR removes will be re-added as we build up more functionality in the emitter and as we migrate the Azure Core to depend on this unbranded package. However, removing all but the essentials up front will allow us to be more deliberate about adding API surface and reduces the risk of exposing dead surface.