Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitor] Uprade @azure/monitor-ingestion to ESM/vitest #31615

Merged
merged 23 commits into from
Nov 5, 2024

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/monitor-ingestion

Issues associated with this PR

Describe the problem that is addressed by this PR

Updates to ESM/vitest for @azure/monitor-ingestion.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@github-actions github-actions bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Nov 1, 2024
@mpodwysocki mpodwysocki changed the title Feat/monitor ingestion esm [monitor] Uprade @azure/monitor-ingestion to ESM/vitest Nov 4, 2024
@mpodwysocki mpodwysocki requested a review from ckairen November 4, 2024 19:46
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but overall looks great!

@mpodwysocki mpodwysocki merged commit 1405130 into main Nov 5, 2024
34 checks passed
@mpodwysocki mpodwysocki deleted the feat/monitor-ingestion-esm branch November 5, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants