-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[monitor] Uprade @azure/monitor-ingestion to ESM/vitest #31615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpodwysocki
requested review from
a team,
ckairen,
jeremymeng,
srnagar and
lmolkova
as code owners
November 1, 2024 23:18
mpodwysocki
requested review from
sarangan12,
joshfree,
pvaneck,
KevinBlasko,
scottaddie,
jairmyree and
Haiying-MSFT
November 1, 2024 23:18
ckairen
reviewed
Nov 4, 2024
sdk/monitor/monitor-ingestion/samples-dev/defaultConcurrency.ts
Outdated
Show resolved
Hide resolved
ckairen
reviewed
Nov 4, 2024
mpodwysocki
changed the title
Feat/monitor ingestion esm
[monitor] Uprade @azure/monitor-ingestion to ESM/vitest
Nov 4, 2024
API change check API changes are not detected in this pull request. |
… feat/monitor-ingestion-esm
jeremymeng
reviewed
Nov 5, 2024
jeremymeng
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments but overall looks great!
jeremymeng
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates to ESM/vitest for @azure/monitor-ingestion.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists