Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Render SDK for metadata accuracy, v2 alignment, and latest TypeScript SDK compatibility #31588

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Lakicar95
Copy link
Contributor

This PR updates swagger.md to improve metadata accuracy and align with Customization v2 requirements. Key changes include adding +flavor: azure and + openapi-type: data-plane tags, updating the source-code-folder-path to generated for clearer organization, and setting @autorest/typescript to "latest" for compatibility with the newest TypeScript SDK features.

@github-actions github-actions bot added the Maps label Oct 30, 2024
@Lakicar95 Lakicar95 self-assigned this Oct 30, 2024
@Lakicar95 Lakicar95 requested review from bterlson and a team as code owners October 30, 2024 22:02
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure-rest/maps-render

Copy link
Member

@andykao1213 andykao1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure to mention the readonly prop in the breaking changes. Thanks a lot.

@dubiety
Copy link
Member

dubiety commented Nov 4, 2024

@Azure/azure-sdk-for-js-core , can you help to review this PR and approve the APIview @azure-rest/maps-render? Thank you very much.

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only have one minor comment.

sdk/maps/maps-render-rest/package.json Outdated Show resolved Hide resolved
@Lakicar95 Lakicar95 enabled auto-merge (squash) November 12, 2024 22:56
@Lakicar95 Lakicar95 merged commit 04c92a8 into Azure:main Nov 12, 2024
24 checks passed
@Lakicar95 Lakicar95 deleted the refresh_render branch November 15, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants