Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dev dependency prettier to v3 #26663

Closed
jeremymeng opened this issue Jul 28, 2023 · 2 comments
Closed

Upgrade dev dependency prettier to v3 #26663

jeremymeng opened this issue Jul 28, 2023 · 2 comments
Assignees
@jeremymeng
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@jeremymeng
Copy link
Member

There's some breaking api changes but look easy to fix https://github.com/jeremymeng/azure-sdk-for-js/tree/engsys/prettier-v3

  • One problem is our current pre-commit git hook uses pretty-quick which depends on v2 prettier API and hasn't been updated to depend on prettier v3.
    • maybe we can wait a bit and see if it upgrades to prettier v3
    • or remove the formatting pre-commit hook so its v2 prettier doesn't produce inconsitent changes
@jeremymeng jeremymeng added EngSys This issue is impacting the engineering system. Client This issue points to a problem in the data-plane of the library. labels Jul 28, 2023
@jeremymeng jeremymeng self-assigned this Jul 28, 2023
@jeremymeng
Copy link
Member Author

blocking issue prettier/pretty-quick#164

@jeremymeng
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremymeng jeremymeng

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremymeng