Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the comments for releasing authoring sdk #32128

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

amber-ccc
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 14, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

ContentSafety
Language.Conversations.Authoring
Language.AnalyzeDocuments
Language.Text
Language.Text.Authoring
Language.Conversations
Azure.OpenAI

Copy link

openapi-pipeline-app bot commented Jan 15, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jan 15, 2025

Generated ApiView

Language Package Name ApiView Link
TypeSpec Language.AnalyzeConversations-authoring https://apiview.dev/Assemblies/Review/1a730f703f0e4672a645a7f283b636e8?revisionId=4c588496226d4e898667dc6b0a85838e

@amber-ccc amber-ccc requested review from scgbear and weidongxu-microsoft and removed request for a team January 15, 2025 17:45
/**
* Lists the existing projects.
*/
listProjects is languageOperations.ResourceList<
op listProjects is languageOperations.ResourceList<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's GitHub's rendering, but none of these op lines seem to line up with "tabs". Make sure you run prettier on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adjust the formatting after all the changes are done. Thanks!

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cognitive Services data-plane TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants