Alecb typespecmigration 20240808-preview #31722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-04-03 to stable/2024-09-10.
…e PL. 150+ warnings (mostly for docs) needed
…into alecb-typespecmigration-20240910
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.DesktopVirtualization |
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
AzureRestAPISpecReview
added
the
ReadyForApiTest
…s that a property is missing)
AzureRestAPISpecReview
removed
the
ReadyForApiTest
This was referenced Feb 21, 2025
AzureRestAPISpecReview
added
the
ReadyForApiTest
markcowl
reviewed
Feb 22, 2025
| * Update a session host. | ||
| */ | ||
| @parameterVisibility | ||
| update is ArmCustomPatchSync< |
There was a problem hiding this comment.
This should be changed to:
update is ArmCustomPatchSync<
SessionHost,
SessionHostPatch,
Request - {
/**
* The resource properties to be updated
*/
@bodyRoot sessionHost?: SessionHostPatch;
**
* Force flag to update assign, unassign or reassign personal desktop.
*/
@query("force")
force?: boolean;
}
>;This will make the force parameter come after the request body
| /** | ||
| * The resource properties to be updated | ||
| */ | ||
| @bodyRoot scalingPlanPersonalSchedule?: ScalingPlanPersonalSchedulePatch; |
There was a problem hiding this comment.
Suggested change
| @bodyRoot scalingPlanPersonalSchedule?: ScalingPlanPersonalSchedulePatch; | |
| @bodyRoot scalingPlanSchedule?: ScalingPlanPersonalSchedulePatch; |
| /** | ||
| * The resource properties to be updated | ||
| */ | ||
| @bodyRoot scalingPlanPooledSchedule?: ScalingPlanPooledSchedulePatch; |
There was a problem hiding this comment.
Suggested change
| @bodyRoot scalingPlanPooledSchedule?: ScalingPlanPooledSchedulePatch; | |
| @bodyRoot scalingPlanSchedule?: ScalingPlanPooledSchedulePatch; |
markcowl
reviewed
Feb 22, 2025
| @parentResource(HostPool) | ||
| @singleton("default") | ||
| model SessionHostConfiguration | ||
| is Azure.ResourceManager.ProxyResource<SessionHostConfigurationProperties> { |
There was a problem hiding this comment.
Suggested change
| is Azure.ResourceManager.ProxyResource<SessionHostConfigurationProperties> { | |
| is Azure.ResourceManager.ProxyResource<SessionHostConfigurationProperties, false> { |
| `import` is ArmResourceActionSync< | ||
| HostPool, | ||
| Request = { | ||
| @bodyRoot importPackageInfoRequest?: ImportPackageInfoRequest; |
There was a problem hiding this comment.
Suggested change
| @bodyRoot importPackageInfoRequest?: ImportPackageInfoRequest; | |
| @bodyRoot importPackageInfoRequest: ImportPackageInfoRequest; |
| expand is ArmResourceActionSync< | ||
| HostPool, | ||
| Request = { | ||
| @bodyRoot msixImageURI?: MSIXImageURI; |
There was a problem hiding this comment.
Suggested change
| @bodyRoot msixImageURI?: MSIXImageURI; | |
| @bodyRoot msixImageURI: MSIXImageURI; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.