From c54a9f3790dca30dbbd8916047c69b35da02ed1a Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:25:17 -0700 Subject: [PATCH 01/42] simple test --- .github/workflows/validate-build.yml | 31 ++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/workflows/validate-build.yml diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml new file mode 100644 index 000000000..9645ef0c1 --- /dev/null +++ b/.github/workflows/validate-build.yml @@ -0,0 +1,31 @@ +name: Validate Build + +on: + push: + branches: + - main + - 'dajusto/add-tests-as-gh-action' + paths-ignore: [ '**.md' ] + pull_request: + branches: + - main + paths-ignore: [ '**.md' ] + +env: + solution: WebJobs.Extensions.DurableTask.sln + config: Release + +jobs: + build: + runs-on: windows-latest + + steps: + - uses: actions/checkout@v3 + with: + submodules: true + + - name: Setup .NET + uses: actions/setup-dotnet@v3 + + - name: Restore dependencies + run: dotnet restore $solution \ No newline at end of file From 727aff94b639c7ce9379995d319b7ee7e10dfa73 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:28:01 -0700 Subject: [PATCH 02/42] add this branch for tests --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 9645ef0c1..6b6edbc48 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -4,7 +4,7 @@ on: push: branches: - main - - 'dajusto/add-tests-as-gh-action' + - dajusto/run-tests-in-gh-action paths-ignore: [ '**.md' ] pull_request: branches: From aa04a2a92203a52155d561277f50df2ef610f8cf Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:37:27 -0700 Subject: [PATCH 03/42] add test step --- .github/workflows/validate-build.yml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 6b6edbc48..c664b09f5 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -15,6 +15,14 @@ env: solution: WebJobs.Extensions.DurableTask.sln config: Release +services: + azurite: + image: mcr.microsoft.com/azure-storage/azurite + ports: + - 10000:10000 + - 10001:10001 + - 10002:10002 + jobs: build: runs-on: windows-latest @@ -28,4 +36,10 @@ jobs: uses: actions/setup-dotnet@v3 - name: Restore dependencies - run: dotnet restore $solution \ No newline at end of file + run: dotnet restore $solution + + - name: Build + run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + + - name: Test DTx.Core + run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 7eb6c48d246bf0a60ff010e940c11e92fc1bead9 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:39:44 -0700 Subject: [PATCH 04/42] refactor services --- .github/workflows/validate-build.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index c664b09f5..be479f4aa 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -15,18 +15,18 @@ env: solution: WebJobs.Extensions.DurableTask.sln config: Release -services: - azurite: - image: mcr.microsoft.com/azure-storage/azurite - ports: - - 10000:10000 - - 10001:10001 - - 10002:10002 - jobs: build: runs-on: windows-latest + services: + azurite: + image: mcr.microsoft.com/azure-storage/azurite + ports: + - 10000:10000 + - 10001:10001 + - 10002:10002 + steps: - uses: actions/checkout@v3 with: From 974ec958714ca92a394e7b62dc6a4afb2b50a347 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:43:31 -0700 Subject: [PATCH 05/42] add azurite step --- .github/workflows/validate-build.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index be479f4aa..5c3cb40cc 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -19,14 +19,6 @@ jobs: build: runs-on: windows-latest - services: - azurite: - image: mcr.microsoft.com/azure-storage/azurite - ports: - - 10000:10000 - - 10001:10001 - - 10002:10002 - steps: - uses: actions/checkout@v3 with: @@ -41,5 +33,10 @@ jobs: - name: Build run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + - name: Run Azurite + run: | + docker pull mcr.microsoft.com/azure-storage/azurite + docker run -d -p 10000:10000 -p 10001:10001 -p 10002:10002 --name azurite mcr.microsoft.com/azure-storage/azurite + - name: Test DTx.Core run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 832d6d8a99a53f99e7834675d2ae396e761ef1c2 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 14:50:49 -0700 Subject: [PATCH 06/42] add .net core app 3.1 --- .github/workflows/validate-build.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 5c3cb40cc..cd4013626 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -27,6 +27,11 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v3 + - name: Set up .NET Core 3.1 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '3.1.x' + - name: Restore dependencies run: dotnet restore $solution From f5af9365df7152c35f29e28ea0513c91824804a3 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 15:02:03 -0700 Subject: [PATCH 07/42] add .net core 2.1 --- .github/workflows/validate-build.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index cd4013626..81277a52b 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -32,6 +32,11 @@ jobs: with: dotnet-version: '3.1.x' + - name: Set up .NET Core 321 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '2.1.x' + - name: Restore dependencies run: dotnet restore $solution From 25deebdf59531c05ab38001f590d46e5e9bd2620 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 15:12:52 -0700 Subject: [PATCH 08/42] change azurite to install via npm --- .github/workflows/validate-build.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 81277a52b..7f159016b 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -43,10 +43,16 @@ jobs: - name: Build run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true - - name: Run Azurite - run: | - docker pull mcr.microsoft.com/azure-storage/azurite - docker run -d -p 10000:10000 -p 10001:10001 -p 10002:10002 --name azurite mcr.microsoft.com/azure-storage/azurite + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: '16.x' + + - name: Install Azurite + run: npm install -g azurite + + - name: Start Azurite + run: azurite --silent & - name: Test DTx.Core run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 1765f804a1c20a439b58bf134572934b1715014e Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 15:20:00 -0700 Subject: [PATCH 09/42] add worker runtime --- .github/workflows/validate-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 7f159016b..757fe8f25 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -14,6 +14,7 @@ on: env: solution: WebJobs.Extensions.DurableTask.sln config: Release + FUNCTIONS_WORKER_RUNTIME: dotnet jobs: build: From 0f762e9bc2abb68093ec22610ab5b65940734916 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 15:30:56 -0700 Subject: [PATCH 10/42] add azstoragge env var --- .github/workflows/validate-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 757fe8f25..a7648e843 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -15,6 +15,7 @@ env: solution: WebJobs.Extensions.DurableTask.sln config: Release FUNCTIONS_WORKER_RUNTIME: dotnet + AzureWebJobsStorage: UseDevelopmentStorage=true jobs: build: From 17a69aeb886416be8e771e0422216166dd488182 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:14:48 -0700 Subject: [PATCH 11/42] speified queue port --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index a7648e843..f0ac58429 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,7 +54,7 @@ jobs: run: npm install -g azurite - name: Start Azurite - run: azurite --silent & + run: azurite --silent --queuePort 10001 & - name: Test DTx.Core run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 509f4e7bfc9a4ef3f105de6dda5db01a891fcb89 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:22:55 -0700 Subject: [PATCH 12/42] add azurite ports --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index f0ac58429..c8a603f41 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,7 +54,7 @@ jobs: run: npm install -g azurite - name: Start Azurite - run: azurite --silent --queuePort 10001 & + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & - name: Test DTx.Core run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From b43df4765bdad4dce51571773637a0c5aefd57c8 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:34:05 -0700 Subject: [PATCH 13/42] start azurite and run tests --- .github/workflows/validate-build.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index c8a603f41..3987ac5f3 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -53,8 +53,5 @@ jobs: - name: Install Azurite run: npm install -g azurite - - name: Start Azurite - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & - - name: Test DTx.Core - run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 975702b385555d382c3b3bd92c907e18acb5f823 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:46:29 -0700 Subject: [PATCH 14/42] install emulator --- .github/workflows/validate-build.yml | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 3987ac5f3..1d9b712b8 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -45,13 +45,24 @@ jobs: - name: Build run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true - - name: Set up Node.js - uses: actions/setup-node@v3 - with: - node-version: '16.x' + # - name: Set up Node.js + # uses: actions/setup-node@v3 + # with: + # node-version: '16.x' + + # - name: Install Azurite + # run: npm install -g azurite + + - name: Install Azure Storage Emulator + run: | + curl -L -o azurestorageemulator.msi "https://download.microsoft.com/download/C/1/9/C1902F99-2183-49E0-BFC8-A7B6E2D8A62E/MicrosoftAzureStorageEmulator.msi" + msiexec /i azurestorageemulator.msi /quiet + + - name: Start Azure Storage Emulator + run: | + "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" init + "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" start - - name: Install Azurite - run: npm install -g azurite - name: Test DTx.Core - run: azurite --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 7159630e9e12be9fe40f0f1f960c7b2d6ac33ec2 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:52:23 -0700 Subject: [PATCH 15/42] install emulator early --- .github/workflows/validate-build.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 1d9b712b8..378491cdb 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -29,6 +29,17 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v3 + - name: Install Azure Storage Emulator + run: | + curl -L -o azurestorageemulator.msi "https://download.microsoft.com/download/C/1/9/C1902F99-2183-49E0-BFC8-A7B6E2D8A62E/MicrosoftAzureStorageEmulator.msi" + msiexec /i azurestorageemulator.msi /quiet + + - name: Start Azure Storage Emulator + shell: cmd + run: | + "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" init + "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" start + - name: Set up .NET Core 3.1 uses: actions/setup-dotnet@v3 with: @@ -53,16 +64,5 @@ jobs: # - name: Install Azurite # run: npm install -g azurite - - name: Install Azure Storage Emulator - run: | - curl -L -o azurestorageemulator.msi "https://download.microsoft.com/download/C/1/9/C1902F99-2183-49E0-BFC8-A7B6E2D8A62E/MicrosoftAzureStorageEmulator.msi" - msiexec /i azurestorageemulator.msi /quiet - - - name: Start Azure Storage Emulator - run: | - "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" init - "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" start - - - name: Test DTx.Core run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file From 27fe08df589e99041a96ceeb98a5e8e44e449a9d Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:53:51 -0700 Subject: [PATCH 16/42] do not install emulator quietly --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 378491cdb..9fb5aaa63 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -32,7 +32,7 @@ jobs: - name: Install Azure Storage Emulator run: | curl -L -o azurestorageemulator.msi "https://download.microsoft.com/download/C/1/9/C1902F99-2183-49E0-BFC8-A7B6E2D8A62E/MicrosoftAzureStorageEmulator.msi" - msiexec /i azurestorageemulator.msi /quiet + msiexec /i azurestorageemulator.msi - name: Start Azure Storage Emulator shell: cmd From 4cebccd55f14ee146e3ebdf63ba8a635fd43895c Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 16:59:44 -0700 Subject: [PATCH 17/42] filter tests more aggressively --- .github/workflows/validate-build.yml | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 9fb5aaa63..32344487e 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -29,17 +29,6 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v3 - - name: Install Azure Storage Emulator - run: | - curl -L -o azurestorageemulator.msi "https://download.microsoft.com/download/C/1/9/C1902F99-2183-49E0-BFC8-A7B6E2D8A62E/MicrosoftAzureStorageEmulator.msi" - msiexec /i azurestorageemulator.msi - - - name: Start Azure Storage Emulator - shell: cmd - run: | - "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" init - "C:\Program Files (x86)\Microsoft SDKs\Azure\Storage Emulator\AzureStorageEmulator.exe" start - - name: Set up .NET Core 3.1 uses: actions/setup-dotnet@v3 with: @@ -56,13 +45,13 @@ jobs: - name: Build run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true - # - name: Set up Node.js - # uses: actions/setup-node@v3 - # with: - # node-version: '16.x' + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: '16.x' - # - name: Install Azurite - # run: npm install -g azurite + - name: Install Azurite + run: npm install -g azurite - name: Test DTx.Core - run: dotnet test #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj #--configuration $config --no-build --verbosity normal \ No newline at end of file From 8e89a478d39feba599dcb811b66bbca8569728e4 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 17:24:13 -0700 Subject: [PATCH 18/42] make azurite silent --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 32344487e..6ed4a0d56 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,4 +54,4 @@ jobs: run: npm install -g azurite - name: Test DTx.Core - run: azurite --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj #--configuration $config --no-build --verbosity normal \ No newline at end of file From 7749dc30dc3c313d081befd5c43f19e540fe6181 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 18:07:29 -0700 Subject: [PATCH 19/42] specify singular test --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 6ed4a0d56..be2f61adf 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,4 +54,4 @@ jobs: run: npm install -g azurite - name: Test DTx.Core - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~OutOfProcTests.TestLocalRcpEndpointRuntimeVersion"#--configuration $config --no-build --verbosity normal \ No newline at end of file From 4a3d39cae5b2544816a7d6f4a7fb676f7684f1d2 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 18:20:53 -0700 Subject: [PATCH 20/42] remove warnings, refine tests --- .../WebJobs.Extensions.DurableTask.csproj | 2 +- test/FunctionsV2/OutOfProcTests.cs | 5 ++++- test/SmokeTests/SmokeTestsV1/VSSampleV1.csproj | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj b/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj index 914aff257..5b6d2b4a7 100644 --- a/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj +++ b/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj @@ -57,7 +57,7 @@ - + diff --git a/test/FunctionsV2/OutOfProcTests.cs b/test/FunctionsV2/OutOfProcTests.cs index 4f95c1a2b..4fb60654d 100644 --- a/test/FunctionsV2/OutOfProcTests.cs +++ b/test/FunctionsV2/OutOfProcTests.cs @@ -342,9 +342,12 @@ public async Task TestLocalRcpEndpointRuntimeVersion(string runtimeVersion, bool // Validate if we opened local RPC endpoint by looking at log statements. var logger = this.loggerProvider.CreatedLoggers.Single(l => l.Category == TestHelpers.LogCategory); var logMessages = logger.LogMessages.ToList(); + + Assert.True(logMessages.Count > 0, "No log messages found."); + bool enabledRpcEndpoint = logMessages.Any(msg => msg.Level == Microsoft.Extensions.Logging.LogLevel.Information && msg.FormattedMessage.StartsWith($"Opened local {expectedProtocol} endpoint:")); - Assert.Equal(enabledExpected, enabledRpcEndpoint); + Assert.Equal(enabledExpected, enabledRpcEndpoint, ); await host.StopAsync(); } diff --git a/test/SmokeTests/SmokeTestsV1/VSSampleV1.csproj b/test/SmokeTests/SmokeTestsV1/VSSampleV1.csproj index 1d2b30732..304a6fe3b 100644 --- a/test/SmokeTests/SmokeTestsV1/VSSampleV1.csproj +++ b/test/SmokeTests/SmokeTestsV1/VSSampleV1.csproj @@ -10,7 +10,6 @@ - From 1a9b6e31f5d6f1c4da3af78b27ff93b5d3769972 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 18:26:24 -0700 Subject: [PATCH 21/42] remove typo --- .github/workflows/validate-build.yml | 2 +- test/FunctionsV2/OutOfProcTests.cs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index be2f61adf..4e2d5c4d6 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -34,7 +34,7 @@ jobs: with: dotnet-version: '3.1.x' - - name: Set up .NET Core 321 + - name: Set up .NET Core 2.1 uses: actions/setup-dotnet@v3 with: dotnet-version: '2.1.x' diff --git a/test/FunctionsV2/OutOfProcTests.cs b/test/FunctionsV2/OutOfProcTests.cs index 4fb60654d..db1b9063e 100644 --- a/test/FunctionsV2/OutOfProcTests.cs +++ b/test/FunctionsV2/OutOfProcTests.cs @@ -344,10 +344,11 @@ public async Task TestLocalRcpEndpointRuntimeVersion(string runtimeVersion, bool var logMessages = logger.LogMessages.ToList(); Assert.True(logMessages.Count > 0, "No log messages found."); + Console.WriteLine(logMessages); bool enabledRpcEndpoint = logMessages.Any(msg => msg.Level == Microsoft.Extensions.Logging.LogLevel.Information && msg.FormattedMessage.StartsWith($"Opened local {expectedProtocol} endpoint:")); - Assert.Equal(enabledExpected, enabledRpcEndpoint, ); + Assert.Equal(enabledExpected, enabledRpcEndpoint); await host.StopAsync(); } From 6e1a7f881329a1e8e540ae7c6d8178d0b5f4b4ac Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 18:37:56 -0700 Subject: [PATCH 22/42] fix some issues --- .github/workflows/validate-build.yml | 1 - .../WebJobs.Extensions.DurableTask.csproj | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 4e2d5c4d6..061c4e047 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -14,7 +14,6 @@ on: env: solution: WebJobs.Extensions.DurableTask.sln config: Release - FUNCTIONS_WORKER_RUNTIME: dotnet AzureWebJobsStorage: UseDevelopmentStorage=true jobs: diff --git a/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj b/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj index 5b6d2b4a7..0b17fee29 100644 --- a/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj +++ b/src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj @@ -57,7 +57,7 @@ - + From 4da264594618c6deb7e4991acbcc3c3e18157c5d Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 18:45:31 -0700 Subject: [PATCH 23/42] remove filter --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 061c4e047..e28626755 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -53,4 +53,4 @@ jobs: run: npm install -g azurite - name: Test DTx.Core - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~OutOfProcTests.TestLocalRcpEndpointRuntimeVersion"#--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~OutOfProcTests.TestLocalRcpEndpointRuntimeVersion" #--configuration $config --no-build --verbosity normal \ No newline at end of file From aa0a5d1f9c163f77d59a671443525638bfeb16fb Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 19:10:22 -0700 Subject: [PATCH 24/42] check clean entity test --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index e28626755..c4b0b6077 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -53,4 +53,4 @@ jobs: run: npm install -g azurite - name: Test DTx.Core - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~OutOfProcTests.TestLocalRcpEndpointRuntimeVersion" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" #--configuration $config --no-build --verbosity normal \ No newline at end of file From 0e1bc4c7a4ba4a8e41c401befba6bd39298f086f Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 19:25:54 -0700 Subject: [PATCH 25/42] fix some tests, and warnings --- test/Common/TestDurableClient.cs | 2 +- test/Common/TestHelpers.cs | 2 +- test/FunctionsV2/CorrelationEndToEndTests.cs | 6 +++--- test/FunctionsV2/OutOfProcTests.cs | 2 ++ test/FunctionsV2/PlatformSpecificHelpers.FunctionsV2.cs | 3 ++- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/test/Common/TestDurableClient.cs b/test/Common/TestDurableClient.cs index d9f41d4c4..6e35e5e49 100644 --- a/test/Common/TestDurableClient.cs +++ b/test/Common/TestDurableClient.cs @@ -182,7 +182,7 @@ public async Task WaitForCompletionAsync( { if (timeout == null) { - timeout = Debugger.IsAttached ? TimeSpan.FromMinutes(5) : TimeSpan.FromSeconds(30); + timeout = Debugger.IsAttached ? TimeSpan.FromMinutes(5) : TimeSpan.FromMinutes(1); } Stopwatch sw = Stopwatch.StartNew(); diff --git a/test/Common/TestHelpers.cs b/test/Common/TestHelpers.cs index 83259db08..e89c09978 100644 --- a/test/Common/TestHelpers.cs +++ b/test/Common/TestHelpers.cs @@ -12,8 +12,8 @@ using DurableTask.AzureStorage; using Microsoft.ApplicationInsights.Channel; #if !FUNCTIONS_V1 -using Microsoft.Extensions.Hosting; using Microsoft.Azure.WebJobs.Host.Scale; +using Microsoft.Extensions.Hosting; #endif using Microsoft.Azure.WebJobs.Host.TestCommon; using Microsoft.Extensions.Logging; diff --git a/test/FunctionsV2/CorrelationEndToEndTests.cs b/test/FunctionsV2/CorrelationEndToEndTests.cs index 0b9e31eac..62beaabfe 100644 --- a/test/FunctionsV2/CorrelationEndToEndTests.cs +++ b/test/FunctionsV2/CorrelationEndToEndTests.cs @@ -234,7 +234,7 @@ internal async Task, List>> [InlineData(false, true, true)] [InlineData(true, true, false)] [InlineData(true, true, true)] - public async void TelemetryClientSetup_AppInsights_Warnings(bool instrumentationKeyIsSet, bool connStringIsSet, bool extendedSessions) + public void TelemetryClientSetup_AppInsights_Warnings(bool instrumentationKeyIsSet, bool connStringIsSet, bool extendedSessions) { TraceOptions traceOptions = new TraceOptions() { @@ -258,11 +258,11 @@ public async void TelemetryClientSetup_AppInsights_Warnings(bool instrumentation } else if (instrumentationKeyIsSet) { - mockNameResolver = GetNameResolverMock(new[] { (instKeyEnvVarName, environmentVariableValue), (connStringEnvVarName, String.Empty) }); + mockNameResolver = GetNameResolverMock(new[] { (instKeyEnvVarName, environmentVariableValue), (connStringEnvVarName, string.Empty) }); } else if (connStringIsSet) { - mockNameResolver = GetNameResolverMock(new[] { (instKeyEnvVarName, String.Empty), (connStringEnvVarName, connStringValue) }); + mockNameResolver = GetNameResolverMock(new[] { (instKeyEnvVarName, string.Empty), (connStringEnvVarName, connStringValue) }); } using (var host = TestHelpers.GetJobHost( diff --git a/test/FunctionsV2/OutOfProcTests.cs b/test/FunctionsV2/OutOfProcTests.cs index db1b9063e..f8184a496 100644 --- a/test/FunctionsV2/OutOfProcTests.cs +++ b/test/FunctionsV2/OutOfProcTests.cs @@ -367,6 +367,7 @@ public async Task InvokeLocalRpcEndpoint() { await host.StartAsync(); +#pragma warning disable SYSLIB0014 // Type or member is obsolete using (var client = new WebClient()) { string jsonString = client.DownloadString("http://localhost:17071/durabletask/instances"); @@ -374,6 +375,7 @@ public async Task InvokeLocalRpcEndpoint() // The result is expected to be an empty array JArray array = JArray.Parse(jsonString); } +#pragma warning restore SYSLIB0014 // Type or member is obsolete await host.StopAsync(); } diff --git a/test/FunctionsV2/PlatformSpecificHelpers.FunctionsV2.cs b/test/FunctionsV2/PlatformSpecificHelpers.FunctionsV2.cs index 4b2d46456..428b93c9d 100644 --- a/test/FunctionsV2/PlatformSpecificHelpers.FunctionsV2.cs +++ b/test/FunctionsV2/PlatformSpecificHelpers.FunctionsV2.cs @@ -230,7 +230,6 @@ private static IWebJobsBuilder AddEmulatorDurableTask(this IWebJobsBuilder build internal class FunctionsV2HostWrapper : ITestHost { - internal readonly IHost InnerHost; private readonly JobHost innerWebJobsHost; private readonly DurableTaskOptions options; private readonly INameResolver nameResolver; @@ -255,6 +254,8 @@ internal FunctionsV2HostWrapper( this.options = options.Value; } + internal IHost InnerHost { get; private set; } + public Task CallAsync(string methodName, IDictionary args) => this.innerWebJobsHost.CallAsync(methodName, args); From 0fade5a99307c3d01ed875a76000de61684429f0 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 19:34:40 -0700 Subject: [PATCH 26/42] fix warnings, allow more tests --- .github/workflows/validate-build.yml | 4 ++-- .../WebJobs.Extensions.DurableTask.Analyzers.csproj | 1 + test/Common/DurableTaskEndToEndTests.cs | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index c4b0b6077..16b75fed8 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -47,10 +47,10 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version: '18.x' # Azurite requires at least Node 18 - name: Install Azurite run: npm install -g azurite - name: Test DTx.Core - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" #--configuration $config --no-build --verbosity normal \ No newline at end of file diff --git a/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj b/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj index be27d32a9..c0a9ff70e 100644 --- a/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj +++ b/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj @@ -4,6 +4,7 @@ netstandard2.0 false true + RS1026 diff --git a/test/Common/DurableTaskEndToEndTests.cs b/test/Common/DurableTaskEndToEndTests.cs index 1044eddab..3439d65bb 100644 --- a/test/Common/DurableTaskEndToEndTests.cs +++ b/test/Common/DurableTaskEndToEndTests.cs @@ -4299,7 +4299,7 @@ public async Task DurableEntity_EntityProxy_NameResolve(bool extendedSessions) } /// - /// Test which validates that entity state deserialization + /// Test which validates that entity state deserialization. /// [Theory] [InlineData(true)] From 6432f5dcf6a4ea4432bca3ccd88095cc3da5027d Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 19:57:25 -0700 Subject: [PATCH 27/42] run test --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 16b75fed8..0dd4d2cb6 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -53,4 +53,4 @@ jobs: run: npm install -g azurite - name: Test DTx.Core - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From 585e4a69dbef99c41293706cb458a0233a2d99ea Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 20:08:04 -0700 Subject: [PATCH 28/42] stabilize tests --- .github/workflows/validate-build.yml | 6 ++++-- test/Common/DurableTaskEndToEndTests.cs | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 0dd4d2cb6..10ab76a44 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -44,7 +44,8 @@ jobs: - name: Build run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true - - name: Set up Node.js + # Install Azurite + - name: Set up Node.js (needed for Azurite) uses: actions/setup-node@v3 with: node-version: '18.x' # Azurite requires at least Node 18 @@ -52,5 +53,6 @@ jobs: - name: Install Azurite run: npm install -g azurite - - name: Test DTx.Core + # Run tests + - name: Test FunctionsV2 tests run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file diff --git a/test/Common/DurableTaskEndToEndTests.cs b/test/Common/DurableTaskEndToEndTests.cs index 3439d65bb..57eb8f532 100644 --- a/test/Common/DurableTaskEndToEndTests.cs +++ b/test/Common/DurableTaskEndToEndTests.cs @@ -746,6 +746,9 @@ await TestHelpers.WaitUntilTrue( conditionDescription: "Log file exists", timeout: TimeSpan.FromSeconds(30)); + // add a minute wait to ensure logs are fully written + await Task.Delay(TimeSpan.FromMinutes(1)); + await TestHelpers.WaitUntilTrue( predicate: () => { From 124b252d6a6474a734f7d5b1b2f13f084a507faf Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 20:17:05 -0700 Subject: [PATCH 29/42] remove write line --- test/FunctionsV2/CorrelationEndToEndTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/FunctionsV2/CorrelationEndToEndTests.cs b/test/FunctionsV2/CorrelationEndToEndTests.cs index 62beaabfe..40a4a4f39 100644 --- a/test/FunctionsV2/CorrelationEndToEndTests.cs +++ b/test/FunctionsV2/CorrelationEndToEndTests.cs @@ -405,13 +405,13 @@ private static List GetCorrelationSortedList(OperationTeleme var result = new List(); if (current.Count != 0) { - foreach (var some in current) + /*foreach (var some in current) { if (parent.Id == some.Context.Operation.ParentId) { Console.WriteLine("match"); } - } + }*/ IOrderedEnumerable nexts = current.Where(p => p.Context.Operation.ParentId == parent.Id).OrderBy(p => p.Timestamp.Ticks); foreach (OperationTelemetry next in nexts) From cdfedd67d6e3169cb3acc39bd85bb8843c8eb169 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 20:17:23 -0700 Subject: [PATCH 30/42] remove filter --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 10ab76a44..fcd32f245 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -55,4 +55,4 @@ jobs: # Run tests - name: Test FunctionsV2 tests - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From cd4420be51de54c49d8033e12e453bd50c5ca707 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 20:39:33 -0700 Subject: [PATCH 31/42] remove end to end tests, for now --- .github/workflows/validate-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index fcd32f245..09a6d954b 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,5 +54,5 @@ jobs: run: npm install -g azurite # Run tests - - name: Test FunctionsV2 tests - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + - name: Run FunctionsV2 tests + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~DurableTaskEndToEndTest.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From 513b68264d0a2dd12046aeb2c20b9e532a160f59 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 20:57:34 -0700 Subject: [PATCH 32/42] trying to fix e2e tests namespace --- .github/workflows/validate-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 09a6d954b..de287f4a1 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -55,4 +55,4 @@ jobs: # Run tests - name: Run FunctionsV2 tests - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~DurableTaskEndToEndTest.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From 709b97f8443702ed4faa26a7745a918c8cd01cfc Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 21:22:03 -0700 Subject: [PATCH 33/42] add parallel e2e tests --- .github/workflows/validate-build-e2e.yml | 58 ++++++++++++++++++++++++ .github/workflows/validate-build.yml | 5 +- 2 files changed, 61 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/validate-build-e2e.yml diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml new file mode 100644 index 000000000..5da37a30e --- /dev/null +++ b/.github/workflows/validate-build-e2e.yml @@ -0,0 +1,58 @@ +name: Validate Build (E2E) + +on: + push: + branches: + - main + - dajusto/run-tests-in-gh-action + paths-ignore: [ '**.md' ] + pull_request: + branches: + - main + paths-ignore: [ '**.md' ] + +env: + solution: WebJobs.Extensions.DurableTask.sln + config: Release + AzureWebJobsStorage: UseDevelopmentStorage=true + +jobs: + build: + runs-on: windows-latest + + steps: + - uses: actions/checkout@v3 + with: + submodules: true + + - name: Setup .NET + uses: actions/setup-dotnet@v3 + + - name: Set up .NET Core 3.1 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '3.1.x' + + - name: Set up .NET Core 2.1 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '2.1.x' + + - name: Restore dependencies + run: dotnet restore $solution + + - name: Build + run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + + # Install Azurite + - name: Set up Node.js (needed for Azurite) + uses: actions/setup-node@v3 + with: + node-version: '18.x' # Azurite requires at least Node 18 + + - name: Install Azurite + run: npm install -g azurite + + # Run tests + - name: Run FunctionsV2 tests (only E2E tests) + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index de287f4a1..450e2a17a 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -54,5 +54,6 @@ jobs: run: npm install -g azurite # Run tests - - name: Run FunctionsV2 tests - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + - name: Run FunctionsV2 tests (except E2E tests) + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal + From b445671a3db1396eece22888750549d9929ede4a Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 21:33:28 -0700 Subject: [PATCH 34/42] fix filter --- .github/workflows/validate-build-e2e.yml | 2 +- .github/workflows/validate-build.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index 5da37a30e..ce15726a2 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -55,4 +55,4 @@ jobs: # Run tests - name: Run FunctionsV2 tests (only E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 450e2a17a..0aa3e9394 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -55,5 +55,5 @@ jobs: # Run tests - name: Run FunctionsV2 tests (except E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.*" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal From d2fc409bab2880ff2cee86d9e381ff0e6f6dbc54 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 21:50:28 -0700 Subject: [PATCH 35/42] remove clean entity storage test (for now) --- .github/workflows/validate-build-e2e.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index ce15726a2..26b992139 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -55,4 +55,5 @@ jobs: # Run tests - name: Run FunctionsV2 tests (only E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj + --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests&FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From a6aedcec0a65dbdc14b3afd3c0f19c09a0d0b96b Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 21:51:26 -0700 Subject: [PATCH 36/42] remove clean entity storage test (for now) --- .github/workflows/validate-build-e2e.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index 26b992139..2863d250a 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -55,5 +55,4 @@ jobs: # Run tests - name: Run FunctionsV2 tests (only E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj - --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests&FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests&FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file From c08bc71fde174d105b93214d52e5a67deaebb776 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 22:13:16 -0700 Subject: [PATCH 37/42] clean up --- .github/workflows/validate-build-e2e.yml | 9 ++++++--- .github/workflows/validate-build.yml | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index 2863d250a..ee335bf48 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -1,4 +1,4 @@ -name: Validate Build (E2E) +name: Validate Build (E2E tests) on: push: @@ -54,5 +54,8 @@ jobs: run: npm install -g azurite # Run tests - - name: Run FunctionsV2 tests (only E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests&FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal \ No newline at end of file + - name: Run FunctionsV2 tests (only DurableEntity_CleanEntityStorage test, which is flaky) + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" + + - name: Run FunctionsV2 tests (all other E2E tests) + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests&FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests.DurableEntity_CleanEntityStorage" \ No newline at end of file diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 0aa3e9394..4587d7006 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -1,4 +1,4 @@ -name: Validate Build +name: Validate Build (except E2E tests) on: push: @@ -55,5 +55,5 @@ jobs: # Run tests - name: Run FunctionsV2 tests (except E2E tests) - run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" # --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" From 1009f6e97e9b99f9b16d2d96952a94d79c1f2ccc Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 22:20:49 -0700 Subject: [PATCH 38/42] add analyzer tests and worker extension tests --- .github/workflows/validate-build-analyzer.yml | 59 +++++++++++++++++++ .github/workflows/validate-build.yml | 3 + 2 files changed, 62 insertions(+) create mode 100644 .github/workflows/validate-build-analyzer.yml diff --git a/.github/workflows/validate-build-analyzer.yml b/.github/workflows/validate-build-analyzer.yml new file mode 100644 index 000000000..7c98ceda5 --- /dev/null +++ b/.github/workflows/validate-build-analyzer.yml @@ -0,0 +1,59 @@ +name: Validate Build (analyzer) + +on: + push: + branches: + - main + - dajusto/run-tests-in-gh-action + paths-ignore: [ '**.md' ] + pull_request: + branches: + - main + paths-ignore: [ '**.md' ] + +env: + solution: WebJobs.Extensions.DurableTask.sln + config: Release + AzureWebJobsStorage: UseDevelopmentStorage=true + +jobs: + build: + runs-on: windows-latest + + steps: + - uses: actions/checkout@v3 + with: + submodules: true + + - name: Setup .NET + uses: actions/setup-dotnet@v3 + + - name: Set up .NET Core 3.1 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '3.1.x' + + - name: Set up .NET Core 2.1 + uses: actions/setup-dotnet@v3 + with: + dotnet-version: '2.1.x' + + - name: Restore dependencies + run: dotnet restore $solution + + - name: Build + run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + + # Install Azurite + - name: Set up Node.js (needed for Azurite) + uses: actions/setup-node@v3 + with: + node-version: '18.x' # Azurite requires at least Node 18 + + - name: Install Azurite + run: npm install -g azurite + + # Run tests + - name: Run Analyzer tests + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/WebJobs.Extensions.DurableTask.Analyzers.Test/WebJobs.Extensions.DurableTask.Analyzers.Test.csproj + diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 4587d7006..33e4cba05 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -57,3 +57,6 @@ jobs: - name: Run FunctionsV2 tests (except E2E tests) run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName!~Microsoft.Azure.WebJobs.Extensions.DurableTask.Tests.DurableTaskEndToEndTests" + - name: Run Worker Extension tests + run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/Worker.Extensions.DurableTask.Tests/Worker.Extensions.DurableTask.Tests.csproj + From d4e5665dfe51192a7a2cf456f989b1bb1a1e1b07 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 22:26:14 -0700 Subject: [PATCH 39/42] clean up --- test/FunctionsV2/CorrelationEndToEndTests.cs | 8 -------- test/FunctionsV2/OutOfProcTests.cs | 3 --- 2 files changed, 11 deletions(-) diff --git a/test/FunctionsV2/CorrelationEndToEndTests.cs b/test/FunctionsV2/CorrelationEndToEndTests.cs index 40a4a4f39..6eb2e9090 100644 --- a/test/FunctionsV2/CorrelationEndToEndTests.cs +++ b/test/FunctionsV2/CorrelationEndToEndTests.cs @@ -405,14 +405,6 @@ private static List GetCorrelationSortedList(OperationTeleme var result = new List(); if (current.Count != 0) { - /*foreach (var some in current) - { - if (parent.Id == some.Context.Operation.ParentId) - { - Console.WriteLine("match"); - } - }*/ - IOrderedEnumerable nexts = current.Where(p => p.Context.Operation.ParentId == parent.Id).OrderBy(p => p.Timestamp.Ticks); foreach (OperationTelemetry next in nexts) { diff --git a/test/FunctionsV2/OutOfProcTests.cs b/test/FunctionsV2/OutOfProcTests.cs index f8184a496..69fa450a5 100644 --- a/test/FunctionsV2/OutOfProcTests.cs +++ b/test/FunctionsV2/OutOfProcTests.cs @@ -343,9 +343,6 @@ public async Task TestLocalRcpEndpointRuntimeVersion(string runtimeVersion, bool var logger = this.loggerProvider.CreatedLoggers.Single(l => l.Category == TestHelpers.LogCategory); var logMessages = logger.LogMessages.ToList(); - Assert.True(logMessages.Count > 0, "No log messages found."); - Console.WriteLine(logMessages); - bool enabledRpcEndpoint = logMessages.Any(msg => msg.Level == Microsoft.Extensions.Logging.LogLevel.Information && msg.FormattedMessage.StartsWith($"Opened local {expectedProtocol} endpoint:")); Assert.Equal(enabledExpected, enabledRpcEndpoint); From 2f63ea3d365524c6e3e3c595c2d648d376330d2e Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 22:27:28 -0700 Subject: [PATCH 40/42] fix indentation --- .../WebJobs.Extensions.DurableTask.Analyzers.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj b/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj index c0a9ff70e..6c627046e 100644 --- a/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj +++ b/src/WebJobs.Extensions.DurableTask.Analyzers/WebJobs.Extensions.DurableTask.Analyzers.csproj @@ -4,7 +4,7 @@ netstandard2.0 false true - RS1026 + RS1026 From 5f04a9e768c343282c86dcfe3c98de435b2b77b8 Mon Sep 17 00:00:00 2001 From: David Justo Date: Tue, 18 Jun 2024 22:28:30 -0700 Subject: [PATCH 41/42] remove commented out --- .github/workflows/validate-build-analyzer.yml | 2 +- .github/workflows/validate-build-e2e.yml | 2 +- .github/workflows/validate-build.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/validate-build-analyzer.yml b/.github/workflows/validate-build-analyzer.yml index 7c98ceda5..82a9c7081 100644 --- a/.github/workflows/validate-build-analyzer.yml +++ b/.github/workflows/validate-build-analyzer.yml @@ -42,7 +42,7 @@ jobs: run: dotnet restore $solution - name: Build - run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + run: dotnet build $solution # Install Azurite - name: Set up Node.js (needed for Azurite) diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index ee335bf48..7dce47544 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -42,7 +42,7 @@ jobs: run: dotnet restore $solution - name: Build - run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + run: dotnet build $solution # Install Azurite - name: Set up Node.js (needed for Azurite) diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 33e4cba05..2ef26219f 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -42,7 +42,7 @@ jobs: run: dotnet restore $solution - name: Build - run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true + run: dotnet build $solution # Install Azurite - name: Set up Node.js (needed for Azurite) From 3495f671f9e722586da7a3dda06617df71f3858c Mon Sep 17 00:00:00 2001 From: David Justo Date: Wed, 19 Jun 2024 09:50:19 -0700 Subject: [PATCH 42/42] removing test branch --- .github/workflows/validate-build-analyzer.yml | 1 - .github/workflows/validate-build-e2e.yml | 1 - .github/workflows/validate-build.yml | 1 - 3 files changed, 3 deletions(-) diff --git a/.github/workflows/validate-build-analyzer.yml b/.github/workflows/validate-build-analyzer.yml index 82a9c7081..ee49e3585 100644 --- a/.github/workflows/validate-build-analyzer.yml +++ b/.github/workflows/validate-build-analyzer.yml @@ -4,7 +4,6 @@ on: push: branches: - main - - dajusto/run-tests-in-gh-action paths-ignore: [ '**.md' ] pull_request: branches: diff --git a/.github/workflows/validate-build-e2e.yml b/.github/workflows/validate-build-e2e.yml index 7dce47544..8290d61e1 100644 --- a/.github/workflows/validate-build-e2e.yml +++ b/.github/workflows/validate-build-e2e.yml @@ -4,7 +4,6 @@ on: push: branches: - main - - dajusto/run-tests-in-gh-action paths-ignore: [ '**.md' ] pull_request: branches: diff --git a/.github/workflows/validate-build.yml b/.github/workflows/validate-build.yml index 2ef26219f..6c23b1198 100644 --- a/.github/workflows/validate-build.yml +++ b/.github/workflows/validate-build.yml @@ -4,7 +4,6 @@ on: push: branches: - main - - dajusto/run-tests-in-gh-action paths-ignore: [ '**.md' ] pull_request: branches: