From 182013e39bab1b2e8dec96e15108d83de04f2605 Mon Sep 17 00:00:00 2001 From: Varshitha Bachu Date: Thu, 18 Apr 2024 16:35:35 -0700 Subject: [PATCH] Update MSSQL smoke test (#2792) This PR removes the SA_PASSWORD hard coded environment variable from the MSSQL smoke test. Instead, a password for the SQL server is set as a repository secret. --- .github/workflows/smoketest-mssql-inproc-v4.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/smoketest-mssql-inproc-v4.yml b/.github/workflows/smoketest-mssql-inproc-v4.yml index 8c373fc5c..e2b25adab 100644 --- a/.github/workflows/smoketest-mssql-inproc-v4.yml +++ b/.github/workflows/smoketest-mssql-inproc-v4.yml @@ -7,18 +7,20 @@ on: paths: - 'src/**' - 'test/SmokeTests/BackendSmokeTests/MSSQL/**' + - '.github/workflows/smoketest-mssql-inproc-v4.yml' pull_request: branches: [ main, dev ] paths: - 'src/**' - 'test/SmokeTests/BackendSmokeTests/MSSQL/**' + - '.github/workflows/smoketest-mssql-inproc-v4.yml' jobs: build: runs-on: ubuntu-latest env: - SA_PASSWORD: NotASecret!12 + SA_PASSWORD: ${{ secrets.SA_PASSWORD }} steps: - uses: actions/checkout@v4