Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ClientOptions updates after client creation #318

Open
j82w opened this issue May 24, 2019 · 2 comments
Open

Prevent ClientOptions updates after client creation #318

j82w opened this issue May 24, 2019 · 2 comments
Labels
discussion-wanted Need a discussion on an area DO NOT MERGE feature-request New feature or request VNext Next Major version of SDK

Comments

@j82w
Copy link
Contributor

j82w commented May 24, 2019 •
edited
Loading

CosmosClient has a clientOptions property that is mutable. This allows users to update value after the client is initialized. Most of these updated values will be ignored, and requires the client to be recreated to be updated. There needs to be a solution to prevent users from updating values the client is using.

Related PR
@j82w j82w added the bug Something isn't working label May 24, 2019
@j82w j82w mentioned this issue May 24, 2019
Merged
3 tasks
@kirankumarkolli
Copy link
Member

Original issue: #314

@kirankumarkolli kirankumarkolli added discussion-wanted Need a discussion on an area DO NOT MERGE feature-request New feature or request and removed bug Something isn't working labels May 24, 2019
@ealsur ealsur mentioned this issue Mar 16, 2022
Closed
@jcocchi
Copy link
Contributor

jcocchi commented Aug 29, 2023

@ealsur/ @kirankumarkolli - sounds like from Matias's note in the linked issue we can't change this in this version. Added a tag for VNext

@jcocchi jcocchi added the VNext Next Major version of SDK label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion-wanted Need a discussion on an area DO NOT MERGE feature-request New feature or request VNext Next Major version of SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcocchi @kirankumarkolli @j82w