Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base item contract to get system properties like ETag #169

Open
j82w opened this issue May 2, 2019 · 4 comments
Open

Add a base item contract to get system properties like ETag #169

j82w opened this issue May 2, 2019 · 4 comments
Labels
discussion-wanted Need a discussion on an area feature-request New feature or request

Comments

@j82w
Copy link
Contributor

j82w commented May 2, 2019

In the v2 .NET SDK it contained a Document class that allowed users to access all the system properties like ETag. Should a contract be added in v3 .NET SDK to expose those same properties where the default JSON serializer will deserialize all the system properties?

Pros:

  • It allows user easy access to the system properties
  • Users get the new properties automatically on upgrading the SDK
  • Prevents user errors caused by incorrectly deserializing the responses
  • Could be expanded to allow easy methods to get partition key and id from the item. This would allow users to only pass the item without needing to explicitly specify the id or pk on item operations.

Cons:

  • Requires users to take a dependency on the SDK type
  • Can cause breaking changes in the future if properties are added based on implementation
  • Not all users will be able to implement or use the provided type
@kirankumarkolli kirankumarkolli added the discussion-wanted Need a discussion on an area label May 9, 2019
@NickSevens
Copy link

Hi @j82w is this still being considered?
I'm currently looking for a solution to retrieve _etag and _ts when using GetItemLinqQueryable().ToFeedIterator().

@j82w
Copy link
Contributor Author

j82w commented Sep 20, 2019

It's still a possibility, but there hasn't been any request for it yet. I think most users have found it easy enough to add the _etag and _ts property to their own objects. We want to make sure that the demand is worth the possible future issues that will come from it.

@lommez
Copy link

lommez commented Jan 30, 2020

Any updates on that feature?

@j82w j82w added the feature-request New feature or request label Mar 23, 2021
@jcocchi
Copy link
Contributor

jcocchi commented Aug 29, 2023

@kirankumarkolli should we consider this now that we have heard a few customer asks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-wanted Need a discussion on an area feature-request New feature or request
Projects
Status: Triage
Development

No branches or pull requests

5 participants